Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't nest scrollbars unnecessarily in the UI #2523

Open
bentveljanzx opened this issue Jan 28, 2025 · 0 comments
Open

Don't nest scrollbars unnecessarily in the UI #2523

bentveljanzx opened this issue Jan 28, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@bentveljanzx
Copy link

bentveljanzx commented Jan 28, 2025

Related ticket

https://temporalsupport.zendesk.com/hc/en-us/requests/9788

TLDR

If rendering a table and it's the last table or thing with its own nested scrollbar, disable that so that it just uses the pages scrollbar instead. Remove the style applied to this kind of div: <div class="paginated-table-wrapper split svelte-1n98w1r" style="max-height: calc(-200px + 100vh);">

This will make scrolling through listings or workflow history a better user experience on desktop/mobile.

Describe the bug

Taken verbatim from the support ticket

For a workflow page, ie, url like: http://localhost:8088/namespaces/default/workflows/GenerateIdWorkflow/2c349f9f-e731-42ea-b519-a3a0aa45a507/history

Is there any plan to make the user interface for the Event History to just use the primary scrollbar rather than nesting because this is very annoying to use since the latest UI changes.

  • The graph section is fine being in its own little window IMO
  • The bottom section that shows things like "Signal, Signal received, Activity" should not use a nested scrollbar, its the "final" thing on the page and i just want to scroll regularly, not click into the window for it. This kind of thing is especially frustrating to use on tablet or mobile.

How to make my change happen:
Underneath <div data-testid="event-summary-table"> there is the following div <div class="paginated-table-wrapper split svelte-1n98w1r" style="max-height: calc(-200px + 100vh);">
If I remove that hard-coded style that makes the height fixed, then this page gives the behaviour I'd want.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a url like:
  1. Look at the table. It has a scrollbar.

Expected behavior

The final table view that has a scrollbar on a page should not have a fixed height and remove the style: style="max-height: calc(-200px + 100vh);"

Screenshots

Cannot provide at this time

Desktop (please complete the following information):

  • OS: Mac
  • Browser: Edge
  • Version [e.g. 22]
  • Temporal UI version in bottom left corner: Version 2.34.0
@bentveljanzx bentveljanzx added the bug Something isn't working label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant