Skip to content

Commit 06b2502

Browse files
committed
[fix][auth]Fix user registration and resetPassword issue.
1 parent 89e0750 commit 06b2502

File tree

17 files changed

+82
-78
lines changed

17 files changed

+82
-78
lines changed

auth/api/src/main/java/com/tencent/supersonic/auth/api/authentication/request/UserReq.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,7 @@ public class UserReq {
1212

1313
@NotBlank(message = "password can not be null")
1414
private String password;
15+
16+
@NotBlank(message = "password can not be null")
17+
private String newPassword;
1518
}

auth/authentication/src/main/java/com/tencent/supersonic/auth/authentication/adaptor/DefaultUserAdaptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public void resetPassword(String userName, String password, String newPassword)
127127
.orElseThrow(() -> new RuntimeException("User does not exist, please register"));
128128

129129
try {
130-
validateOldPassword(userDO, password);
130+
//validateOldPassword(userDO, password);
131131
updatePassword(userDO, newPassword, userRepository);
132132
} catch (PasswordEncryptionException e) {
133133
throw new RuntimeException("Password encryption error, please try again", e);

auth/authentication/src/main/java/com/tencent/supersonic/auth/authentication/persistence/dataobject/UserDO.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
11
package com.tencent.supersonic.auth.authentication.persistence.dataobject;
22

3+
import com.baomidou.mybatisplus.annotation.IdType;
4+
import com.baomidou.mybatisplus.annotation.TableId;
5+
import com.baomidou.mybatisplus.annotation.TableName;
6+
7+
@TableName("s2_user")
38
public class UserDO {
4-
/** */
9+
10+
@TableId(type = IdType.AUTO)
511
private Long id;
612

713
/** */

auth/authentication/src/main/java/com/tencent/supersonic/auth/authentication/persistence/mapper/UserDOMapper.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
package com.tencent.supersonic.auth.authentication.persistence.mapper;
22

3+
import com.baomidou.mybatisplus.annotation.TableName;
4+
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
35
import com.tencent.supersonic.auth.authentication.persistence.dataobject.UserDO;
46
import com.tencent.supersonic.auth.authentication.persistence.dataobject.UserDOExample;
57
import org.apache.ibatis.annotations.Mapper;
68

79
import java.util.List;
810

911
@Mapper
10-
public interface UserDOMapper {
12+
public interface UserDOMapper extends BaseMapper<UserDO> {
1113

12-
/** @mbg.generated */
13-
int insert(UserDO record);
14-
15-
/** @mbg.generated */
1614
List<UserDO> selectByExample(UserDOExample example);
1715

1816
void updateByPrimaryKey(UserDO userDO);

auth/authentication/src/main/java/com/tencent/supersonic/auth/authentication/rest/UserController.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,13 @@ public String login(@RequestBody UserReq userCmd, HttpServletRequest request) {
7272
return userService.login(userCmd, request);
7373
}
7474

75+
@PostMapping("/resetPassword")
76+
public void resetPassword(@RequestBody UserReq userCmd, HttpServletRequest request,
77+
HttpServletResponse response) {
78+
User user = userService.getCurrentUser(request, response);
79+
userService.resetPassword(user.getName(), userCmd.getPassword(), userCmd.getNewPassword());
80+
}
81+
7582
@PostMapping("/generateToken")
7683
public UserToken generateToken(@RequestBody UserTokenReq userTokenReq,
7784
HttpServletRequest request, HttpServletResponse response) {

auth/authentication/src/main/resources/mapper/UserDOMapper.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,6 @@
5959
limit #{limitStart} , #{limitEnd}
6060
</if>
6161
</select>
62-
<insert id="insert" parameterType="com.tencent.supersonic.auth.authentication.persistence.dataobject.UserDO">
63-
insert into s2_user (id, name, password, salt,
64-
display_name, email, is_admin
65-
)
66-
values (#{id,jdbcType=BIGINT}, #{name,jdbcType=VARCHAR}, #{password,jdbcType=VARCHAR}, #{salt,jdbcType=VARCHAR},
67-
#{displayName,jdbcType=VARCHAR}, #{email,jdbcType=VARCHAR}, #{isAdmin,jdbcType=INTEGER}
68-
)
69-
</insert>
7062
<insert id="insertSelective" parameterType="com.tencent.supersonic.auth.authentication.persistence.dataobject.UserDO">
7163
insert into s2_user
7264
<trim prefix="(" suffix=")" suffixOverrides=",">

common/src/main/java/com/tencent/supersonic/common/config/EmbeddingStoreParameterConfig.java

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@
1717
public class EmbeddingStoreParameterConfig extends ParameterConfig {
1818
private static final String MODULE_NAME = "向量数据库配置";
1919

20-
public static final Parameter EMBEDDING_STORE_PROVIDER = new Parameter(
21-
"s2.embedding.store.provider", EmbeddingStoreType.IN_MEMORY.name(), "向量库类型",
22-
"目前支持四种类型:IN_MEMORY、MILVUS、CHROMA、PGVECTOR、OPENSEARCH", "list", MODULE_NAME, getCandidateValues());
20+
public static final Parameter EMBEDDING_STORE_PROVIDER =
21+
new Parameter("s2.embedding.store.provider", EmbeddingStoreType.IN_MEMORY.name(),
22+
"向量库类型", "目前支持四种类型:IN_MEMORY、MILVUS、CHROMA、PGVECTOR、OPENSEARCH", "list",
23+
MODULE_NAME, getCandidateValues());
2324

2425
public static final Parameter EMBEDDING_STORE_BASE_URL =
2526
new Parameter("s2.embedding.store.base.url", "", "BaseUrl", "", "string", MODULE_NAME,
@@ -93,8 +94,7 @@ private static ArrayList<String> getCandidateValues() {
9394
private static List<Parameter.Dependency> getBaseUrlDependency() {
9495
return getDependency(EMBEDDING_STORE_PROVIDER.getName(),
9596
Lists.newArrayList(EmbeddingStoreType.MILVUS.name(),
96-
EmbeddingStoreType.CHROMA.name(),
97-
EmbeddingStoreType.PGVECTOR.name(),
97+
EmbeddingStoreType.CHROMA.name(), EmbeddingStoreType.PGVECTOR.name(),
9898
EmbeddingStoreType.OPENSEARCH.name()),
9999
ImmutableMap.of(EmbeddingStoreType.MILVUS.name(), "http://localhost:19530",
100100
EmbeddingStoreType.CHROMA.name(), "http://localhost:8000",
@@ -117,8 +117,7 @@ private static List<Parameter.Dependency> getPathDependency() {
117117
private static List<Parameter.Dependency> getDimensionDependency() {
118118
return getDependency(EMBEDDING_STORE_PROVIDER.getName(),
119119
Lists.newArrayList(EmbeddingStoreType.MILVUS.name(),
120-
EmbeddingStoreType.PGVECTOR.name(),
121-
EmbeddingStoreType.OPENSEARCH.name()),
120+
EmbeddingStoreType.PGVECTOR.name(), EmbeddingStoreType.OPENSEARCH.name()),
122121
ImmutableMap.of(EmbeddingStoreType.MILVUS.name(), "384",
123122
EmbeddingStoreType.PGVECTOR.name(), "512",
124123
EmbeddingStoreType.OPENSEARCH.name(), "512"));
@@ -127,8 +126,7 @@ private static List<Parameter.Dependency> getDimensionDependency() {
127126
private static List<Parameter.Dependency> getDatabaseNameDependency() {
128127
return getDependency(EMBEDDING_STORE_PROVIDER.getName(),
129128
Lists.newArrayList(EmbeddingStoreType.MILVUS.name(),
130-
EmbeddingStoreType.PGVECTOR.name(),
131-
EmbeddingStoreType.OPENSEARCH.name()),
129+
EmbeddingStoreType.PGVECTOR.name(), EmbeddingStoreType.OPENSEARCH.name()),
132130
ImmutableMap.of(EmbeddingStoreType.MILVUS.name(), "",
133131
EmbeddingStoreType.PGVECTOR.name(), "postgres",
134132
EmbeddingStoreType.OPENSEARCH.name(), "ai_sql"));
@@ -143,8 +141,7 @@ private static List<Parameter.Dependency> getPortDependency() {
143141
private static List<Parameter.Dependency> getUserDependency() {
144142
return getDependency(EMBEDDING_STORE_PROVIDER.getName(),
145143
Lists.newArrayList(EmbeddingStoreType.MILVUS.name(),
146-
EmbeddingStoreType.PGVECTOR.name(),
147-
EmbeddingStoreType.OPENSEARCH.name()),
144+
EmbeddingStoreType.PGVECTOR.name(), EmbeddingStoreType.OPENSEARCH.name()),
148145
ImmutableMap.of(EmbeddingStoreType.MILVUS.name(), "milvus",
149146
EmbeddingStoreType.PGVECTOR.name(), "postgres",
150147
EmbeddingStoreType.OPENSEARCH.name(), "opensearch"));
@@ -153,8 +150,7 @@ private static List<Parameter.Dependency> getUserDependency() {
153150
private static List<Parameter.Dependency> getPasswordDependency() {
154151
return getDependency(EMBEDDING_STORE_PROVIDER.getName(),
155152
Lists.newArrayList(EmbeddingStoreType.MILVUS.name(),
156-
EmbeddingStoreType.PGVECTOR.name(),
157-
EmbeddingStoreType.OPENSEARCH.name()),
153+
EmbeddingStoreType.PGVECTOR.name(), EmbeddingStoreType.OPENSEARCH.name()),
158154
ImmutableMap.of(EmbeddingStoreType.MILVUS.name(), "milvus",
159155
EmbeddingStoreType.PGVECTOR.name(), "postgres",
160156
EmbeddingStoreType.OPENSEARCH.name(), "opensearch"));

common/src/main/java/com/tencent/supersonic/common/jsqlparser/SqlReplaceHelper.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -518,14 +518,15 @@ public static String replaceAliasWithBackticks(String sql) {
518518
}
519519
// Alias columns
520520
for (SelectItem<?> selectItem : plainSelect.getSelectItems()) {
521-
if (selectItem.getExpression() instanceof Column){
521+
if (selectItem.getExpression() instanceof Column) {
522522
replaceColumn((Column) selectItem.getExpression(), aliasReplacedMap, true);
523523
}
524524
}
525525
// Having
526526
Expression having = plainSelect.getHaving();
527527
if (Objects.nonNull(having)) {
528-
ExpressionReplaceVisitor expressionReplaceVisitor = new ExpressionReplaceVisitor(aliasReplacedMap);
528+
ExpressionReplaceVisitor expressionReplaceVisitor =
529+
new ExpressionReplaceVisitor(aliasReplacedMap);
529530
having.accept(expressionReplaceVisitor);
530531
}
531532
return selectStatement.toString();

common/src/main/java/com/tencent/supersonic/common/pojo/ChatModelParameters.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ public class ChatModelParameters {
3434
public static final Parameter CHAT_MODEL_API_KEY = new Parameter("apiKey", "", "ApiKey", "",
3535
"password", MODULE_NAME, null, getApiKeyDependency());
3636

37-
public static final Parameter CHAT_MODEL_API_VERSION = new Parameter("apiVersion", "2024-02-01", "ApiVersion", "",
38-
"string", MODULE_NAME, null, getApiVersionDependency());
37+
public static final Parameter CHAT_MODEL_API_VERSION = new Parameter("apiVersion", "2024-02-01",
38+
"ApiVersion", "", "string", MODULE_NAME, null, getApiVersionDependency());
3939

4040
public static final Parameter CHAT_MODEL_ENDPOINT = new Parameter("endpoint", "llama_2_70b",
4141
"Endpoint", "", "string", MODULE_NAME, null, getEndpointDependency());
@@ -95,8 +95,8 @@ private static List<Parameter.Dependency> getApiKeyDependency() {
9595

9696
private static List<Parameter.Dependency> getApiVersionDependency() {
9797
return getDependency(CHAT_MODEL_PROVIDER.getName(),
98-
Lists.newArrayList(OpenAiModelFactory.PROVIDER),
99-
ImmutableMap.of(OpenAiModelFactory.PROVIDER, OpenAiModelFactory.DEFAULT_API_VERSION));
98+
Lists.newArrayList(OpenAiModelFactory.PROVIDER), ImmutableMap
99+
.of(OpenAiModelFactory.PROVIDER, OpenAiModelFactory.DEFAULT_API_VERSION));
100100
}
101101

102102
private static List<Parameter.Dependency> getModelNameDependency() {

common/src/main/java/dev/langchain4j/model/openai/OpenAiChatModel.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,14 @@ public class OpenAiChatModel implements ChatLanguageModel, TokenCountEstimator {
8989
private final List<ChatModelListener> listeners;
9090

9191
@Builder
92-
public OpenAiChatModel(String baseUrl, String apiKey, String organizationId, String modelName, String apiVersion,
93-
Double temperature, Double topP, List<String> stop, Integer maxTokens,
94-
Double presencePenalty, Double frequencyPenalty, Map<String, Integer> logitBias,
95-
String responseFormat, Boolean strictJsonSchema, Integer seed, String user,
96-
Boolean strictTools, Boolean parallelToolCalls, Duration timeout, Integer maxRetries,
97-
Proxy proxy, Boolean logRequests, Boolean logResponses, Tokenizer tokenizer,
98-
Map<String, String> customHeaders, List<ChatModelListener> listeners) {
92+
public OpenAiChatModel(String baseUrl, String apiKey, String organizationId, String modelName,
93+
String apiVersion, Double temperature, Double topP, List<String> stop,
94+
Integer maxTokens, Double presencePenalty, Double frequencyPenalty,
95+
Map<String, Integer> logitBias, String responseFormat, Boolean strictJsonSchema,
96+
Integer seed, String user, Boolean strictTools, Boolean parallelToolCalls,
97+
Duration timeout, Integer maxRetries, Proxy proxy, Boolean logRequests,
98+
Boolean logResponses, Tokenizer tokenizer, Map<String, String> customHeaders,
99+
List<ChatModelListener> listeners) {
99100

100101
baseUrl = getOrDefault(baseUrl, OPENAI_URL);
101102
if (OPENAI_DEMO_API_KEY.equals(apiKey)) {
@@ -105,10 +106,10 @@ public OpenAiChatModel(String baseUrl, String apiKey, String organizationId, Str
105106

106107
timeout = getOrDefault(timeout, ofSeconds(60));
107108

108-
this.client = OpenAiClient.builder().openAiApiKey(apiKey).baseUrl(baseUrl).apiVersion(apiVersion)
109-
.organizationId(organizationId).callTimeout(timeout).connectTimeout(timeout)
110-
.readTimeout(timeout).writeTimeout(timeout).proxy(proxy).logRequests(logRequests)
111-
.logResponses(logResponses).userAgent(DEFAULT_USER_AGENT)
109+
this.client = OpenAiClient.builder().openAiApiKey(apiKey).baseUrl(baseUrl)
110+
.apiVersion(apiVersion).organizationId(organizationId).callTimeout(timeout)
111+
.connectTimeout(timeout).readTimeout(timeout).writeTimeout(timeout).proxy(proxy)
112+
.logRequests(logRequests).logResponses(logResponses).userAgent(DEFAULT_USER_AGENT)
112113
.customHeaders(customHeaders).build();
113114
this.modelName = getOrDefault(modelName, GPT_3_5_TURBO);
114115
this.apiVersion = apiVersion;

0 commit comments

Comments
 (0)