[improvement](chat) fix checkstyle error in CollectService (#439)

Author: lexluo09

semantic/model/src/main/java/com/tencent/supersonic/semantic/model/application/CollectServiceImpl.java

@@ -5,27 +5,21 @@
 import com.tencent.supersonic.semantic.model.domain.CollectService;
 import com.tencent.supersonic.semantic.model.domain.dataobject.CollectDO;
 import com.tencent.supersonic.semantic.model.infrastructure.mapper.CollectMapper;
+import java.util.List;
+import javax.annotation.Resource;
 import lombok.extern.slf4j.Slf4j;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.springframework.stereotype.Service;
 
-import javax.annotation.Resource;
-import java.util.List;
-
 
 @Slf4j
 @Service
 public class CollectServiceImpl implements CollectService {
 
-
-
+    public static final String type = "metric";
     @Resource
     private CollectMapper collectMapper;
 
-
-    String type = "metric";
-
-
     @Override
     public Boolean createCollectionIndicators(User user, Long id) {
         CollectDO collectDO = new CollectDO();
@@ -39,18 +33,18 @@ public Boolean createCollectionIndicators(User user, Long id) {
     @Override
     public Boolean deleteCollectionIndicators(User user, Long id) {
         QueryWrapper<CollectDO> collectDOQueryWrapper = new QueryWrapper<>();
-        collectDOQueryWrapper.lambda().eq(CollectDO::getUsername,user.getName());
-        collectDOQueryWrapper.lambda().eq(CollectDO::getCollectId,id);
-        collectDOQueryWrapper.lambda().eq(CollectDO::getType,type);
+        collectDOQueryWrapper.lambda().eq(CollectDO::getUsername, user.getName());
+        collectDOQueryWrapper.lambda().eq(CollectDO::getCollectId, id);
+        collectDOQueryWrapper.lambda().eq(CollectDO::getType, type);
         collectMapper.delete(collectDOQueryWrapper);
         return true;
     }
 
     @Override
-    public List<CollectDO> getCollectList(String  username) {
+    public List<CollectDO> getCollectList(String username) {
         QueryWrapper<CollectDO> queryWrapper = new QueryWrapper<>();
-        if (!StringUtils.isEmpty(username)){
-            queryWrapper.lambda().eq(CollectDO::getUsername,username);
+        if (!StringUtils.isEmpty(username)) {
+            queryWrapper.lambda().eq(CollectDO::getUsername, username);
         }
         return collectMapper.selectList(queryWrapper);
     }

semantic/model/src/main/java/com/tencent/supersonic/semantic/model/application/MetricServiceImpl.java

@@ -65,11 +65,11 @@ public class MetricServiceImpl implements MetricService {
     private ApplicationEventPublisher eventPublisher;
 
     public MetricServiceImpl(MetricRepository metricRepository,
-                             ModelService modelService,
-                             DomainService domainService,
-                             ChatGptHelper chatGptHelper,
-                             CollectService collectService,
-                             ApplicationEventPublisher eventPublisher) {
+            ModelService modelService,
+            DomainService domainService,
+            ChatGptHelper chatGptHelper,
+            CollectService collectService,
+            ApplicationEventPublisher eventPublisher) {
         this.domainService = domainService;
         this.metricRepository = metricRepository;
         this.modelService = modelService;
@@ -185,7 +185,7 @@ public PageInfo<MetricResp> queryMetric(PageMetricReq pageMetricReq, User user)
         BeanUtils.copyProperties(metricDOPageInfo, pageInfo);
         List<CollectDO> collectList = collectService.getCollectList(user.getName());
         List<Long> collect = collectList.stream().map(CollectDO::getCollectId).collect(Collectors.toList());
-        List<MetricResp> metricResps = convertList(metricDOPageInfo.getList(),collect);
+        List<MetricResp> metricResps = convertList(metricDOPageInfo.getList(), collect);
         fillAdminRes(metricResps, user);
         pageInfo.setList(metricResps);
         return pageInfo;

semantic/model/src/main/java/com/tencent/supersonic/semantic/model/domain/CollectService.java

@@ -14,7 +14,7 @@ public interface CollectService {
 
     Boolean createCollectionIndicators(User user, Long id);
 
-    Boolean deleteCollectionIndicators(User user,Long id);
+    Boolean deleteCollectionIndicators(User user, Long id);
 
     List<CollectDO> getCollectList(String username);
 

semantic/model/src/main/java/com/tencent/supersonic/semantic/model/domain/utils/MetricConverter.java

@@ -66,9 +66,9 @@ public static MetricResp convert2MetricResp(MetricDO metricDO, Map<Long, ModelRe
             metricResp.setModelName(modelResp.getName());
             metricResp.setDomainId(modelResp.getDomainId());
         }
-        if (collect != null && collect.contains(metricDO.getId())){
+        if (collect != null && collect.contains(metricDO.getId())) {
             metricResp.setIsCollect(true);
-        }else {
+        } else {
             metricResp.setIsCollect(false);
         }
         metricResp.setTag(metricDO.getTags());

semantic/model/src/main/java/com/tencent/supersonic/semantic/model/rest/CollectController.java

@@ -30,19 +30,19 @@ public CollectController(CollectService collectService) {
 
     @PostMapping("/createCollectionIndicators")
     public boolean createCollectionIndicators(@RequestBody CollectDO collectDO,
-                                              HttpServletRequest request,
-                                              HttpServletResponse response) {
+            HttpServletRequest request,
+            HttpServletResponse response) {
         User user = UserHolder.findUser(request, response);
         return collectService.createCollectionIndicators(user, collectDO.getId());
     }
 
 
     @DeleteMapping("/deleteCollectionIndicators/{id}")
     public boolean deleteCollectionIndicators(@PathVariable Long id,
-                                              HttpServletRequest request,
-                                              HttpServletResponse response) {
+            HttpServletRequest request,
+            HttpServletResponse response) {
         User user = UserHolder.findUser(request, response);
-        return collectService.deleteCollectionIndicators(user,id);
+        return collectService.deleteCollectionIndicators(user, id);
     }
 
 }