Fix CI error with Bazel and cleanup:

- fix trimesh_feature_test.py
- fix coverage by adding the missing argument --service=github
- fix and clean rasterizer compilation by using a simple genrule, making the CI also easier to extend to other ops
- Activate rasterizer unit tests and fix issues with shaders and loading the dynamic library
- Run rasterizer unit test using MESA on github action setup proper version for GL and GLSL

PiperOrigin-RevId: 352705180

Author: sofienbouaziz

.bazelrc

@@ -1,5 +1 @@
-build --verbose_failures
-test --keep_going
-test --build_tests_only
-test --test_output=errors
-test --test_verbose_timeout_warnings
+build --verbose_failures

.flake8

@@ -13,6 +13,7 @@ ignore = C901,
          E111,
          E114,
          E121,
+         E124,
          E125,
          E126,
          E129,

.github/workflows/build.yml

@@ -14,38 +14,40 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
-
     - name: Set up Python
-      uses: actions/setup-python@v1
+      uses: actions/setup-python@v2
       with:
-        python-version: 3.x
-
-    - name: Install system dependencies
+        python-version: 3.8
+    - name: Install system requirements
       run: |
         sudo xargs apt-get update
         sudo xargs apt-get -y install < requirements.unix
-    - name: Linter
+    - name: Install pip requirements
       run: |
         python -m pip install --upgrade pip
-        pip install flake8
-        flake8 --config=.flake8 tensorflow_graphics/
-    - name: Build rasterizer
+        pip install -U -r requirements.txt
+        pip install -U pytest coveralls
+        pip install -U flake8
+        pip install -U setuptools wheel
+    - name: Build ops
       run: |
-        docker run -v ${PWD}:/working_dir -w /working_dir  tensorflow/tensorflow:custom-op-ubuntu16 "./build_rasterizer.sh"
-    - name: Install pip requirements
-      run: |
-        pip install -r requirements.txt
-    - name: Test
+        bazel build tensorflow_graphics/... --define=BASEDIR=$(pwd) --sandbox_writable_path=$(pwd)
+        bazel clean --expunge
+    - name: Run python tests and coverage
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        MESA_GL_VERSION_OVERRIDE: 4.5
+        MESA_GLSL_VERSION_OVERRIDE: 450
       run: |
-        pip install pytest coveralls
         coverage run --source tensorflow_graphics -m py.test
-        coveralls
-    - name: Build and Install
+        coveralls --service=github
+    - name: Linter
+      run: |
+        flake8 --config=.flake8 tensorflow_graphics/
+    - name: Build pip package and install
       run: |
         python setup.py sdist bdist_wheel
-        pip install dist/tensorflow_graphics*.whl
+        pip install dist/*.whl
     - name: Test install
       run: |
         cd $(mktemp -d) && python -c 'import tensorflow_graphics as tfg'

.github/workflows/tfg-nigthly-pypi.yml

@@ -13,49 +13,41 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
-
     - name: Set up Python
       uses: actions/setup-python@v2
       with:
-        python-version: '3.x'
-
+        python-version: 3.8
     - name: Install system dependencies
       run: |
         sudo xargs apt-get update
         sudo xargs apt-get -y install < requirements.unix
-    - name: Build rasterizer
-      run: |
-        docker run -v ${PWD}:/working_dir -w /working_dir  tensorflow/tensorflow:custom-op-ubuntu16 "./build_rasterizer.sh"
     - name: Install pip requirements
       run: |
         python -m pip install --upgrade pip
-        pip install setuptools wheel twine pytest
-        pip install -r requirements.txt
-    - name: Test
+        pip install -U -r requirements.txt
+        pip install -U pytest
+        pip install -U setuptools wheel
+        pip install -U twine
+    - name: Build ops
+      run: |
+        bazel build tensorflow_graphics/... --define=BASEDIR=$(pwd) --sandbox_writable_path=$(pwd)
+        bazel clean --expunge
+    - name: Run python tests
+      env:
+        MESA_GL_VERSION_OVERRIDE: 4.5
+        MESA_GLSL_VERSION_OVERRIDE: 450
       run: |
         pytest tensorflow_graphics
-
-    - name: Build nightly
+    - name: Build pip package and install
       run: |
         python setup.py sdist bdist_wheel --nightly
-        
-    - name: Install (and test)
-      run: |
         pip install dist/*.whl
-        cd $(mktemp -d) && python -c 'import tensorflow_graphics as tfg'     
-        
-    # https://pypi.org/project/tfg-nightly
-    - name: Publish to PyPi
+    - name: Test install
+      run: |
+        cd $(mktemp -d) && python -c 'import tensorflow_graphics as tfg'
+    - name: Publish to PyPi # https://pypi.org/project/tfg-nightly
       env:
         TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
         TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
       run: |
-        twine upload dist/* 
-
-    # # https://test.pypi.org/project/tfg-nightly
-    # - name: Publish to test-pypi
-    #   env:
-    #     TWINE_USERNAME: ${{ secrets.TEST_PYPI_USERNAME }}
-    #     TWINE_PASSWORD: ${{ secrets.TEST_PYPI_PASSWORD }}
-    #   run: |
-    #     twine upload --repository testpypi dist/*
+        twine upload dist/*

WORKSPACE

@@ -1,41 +1 @@
 workspace(name = "tensorflow_graphics")
-
-load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
-load("//third_party:tf.bzl", "tf_configure")
-
-
-http_archive(
-    name = "bazel_skylib",
-    url = "https://github.com/bazelbuild/bazel-skylib/releases/download/1.0.0/bazel-skylib-1.0.0.tar.gz",
-    sha256 = "e72747100a8b6002992cc0bf678f6279e71a3fd4a88cab3371ace6c73432be30",
-)
-
-http_archive(
-    name = "io_bazel_rules_closure",
-    sha256 = "9d359cc1b508082d8ba309ba085da6ecec85e7a4d5bd08f8db9666ee39a85529",
-    strip_prefix = "rules_closure-0.9.0",
-    url = "https://github.com/bazelbuild/rules_closure/archive/0.9.0.zip",
-)
-
-http_archive(
-    name = "com_google_googletest",
-    strip_prefix = "googletest-master",
-    urls = ["https://github.com/google/googletest/archive/master.zip"],
-)
-
-http_archive(
-    name = "rules_cc",
-    strip_prefix = "rules_cc-master",
-    urls = ["https://github.com/bazelbuild/rules_cc/archive/master.zip"],
-)
-
-http_archive(
-    name = "com_google_absl",
-    strip_prefix = "abseil-cpp-43ef2148c0936ebf7cb4be6b19927a9d9d145b8f",
-    url = "https://github.com/abseil/abseil-cpp/archive/43ef2148c0936ebf7cb4be6b19927a9d9d145b8f.tar.gz",
-    sha256 = "acd93f6baaedc4414ebd08b33bebca7c7a46888916101d8c0b8083573526d070",
-)
-
-# Set up dependency to tensorflow pip package.
-tf_configure()
-

build_rasterizer.sh

@@ -1,3 +1,3 @@
 [pytest]
-norecursedirs = tensorflow_graphics/rendering/opengl/tests tensorflow_graphics/submodules
+norecursedirs = tensorflow_graphics/submodules
 python_files = *_test.py

pytest.ini

@@ -1,6 +1,6 @@
-tensorflow == 2.2.0
-tensorflow-addons == 0.10.0
-tensorflow-datasets == 2.0.0
+tensorflow >= 2.2.0
+tensorflow-addons >= 0.10.0
+tensorflow-datasets >= 2.0.0
 absl-py >= 0.6.1
 h5py >= 2.10.0
 matplotlib >= 2.2.5

requirements.txt

@@ -66,8 +66,9 @@ def encode_example(self, path_or_trianglemesh):
         features_dict = self._convert_to_trimesh_feature(
             triangle_mesh.load(tmesh_file))
     elif hasattr(path_or_trianglemesh, 'read') and hasattr(
-        path_or_trianglemesh, 'name'):
+        path_or_trianglemesh, 'name') and hasattr(path_or_trianglemesh, 'seek'):
       # The parameter is a file object.
+      path_or_trianglemesh.seek(0)  # reset
       features_dict = self._convert_to_trimesh_feature(
           triangle_mesh.load(path_or_trianglemesh))
     elif isinstance(path_or_trianglemesh, dict):

tensorflow_graphics/datasets/features/trimesh_feature.py

@@ -1,5 +1 @@
-tensorflow_graphics/rendering/opengl/BUILD
-tensorflow_graphics/util/BUILD
-third_party/BUILD
-third_party/preconfig/ubuntu16.04/gcc7_manylinux2010-nvcc-cuda10.1/BUILD
-third_party/preconfig/ubuntu16.04/gcc7_manylinux2010-nvcc-cuda10.1/cc_toolchain_config.bzl
+tensorflow_graphics/rendering/opengl/BUILD