Skip to content

Commit 93e9af4

Browse files
authoredJul 31, 2023
Build node addon before running tests (#7884)
Fix a race condition in CI where the tests may be run before the node addon is built.
1 parent 5974699 commit 93e9af4

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed
 

‎scripts/cloudbuild_tfjs_node_expected.yml

+1
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ steps:
150150
- test-ci
151151
waitFor:
152152
- yarn-tfjs-node
153+
- build-addon-tfjs-node
153154
- lint-tfjs-node
154155
- yarn-common
155156
- yarn-link-package-build

‎tfjs-node-gpu/cloudbuild.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ steps:
5959
entrypoint: 'yarn'
6060
id: 'test'
6161
args: ['test-ci']
62-
waitFor: ['yarn', 'build-deps', 'lint']
62+
waitFor: ['yarn', 'build-addon', 'build-deps', 'lint']
6363

6464
# CPU / GPU package alignment.
6565
- name: 'gcr.io/learnjs-174218/release'

‎tfjs-node/cloudbuild.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ steps:
5151
entrypoint: 'yarn'
5252
id: 'test'
5353
args: ['test-ci']
54-
waitFor: ['yarn', 'build-deps', 'lint']
54+
waitFor: ['yarn', 'build-addon', 'build-deps', 'lint']
5555

5656
# CPU / GPU package alignment.
5757
- name: 'gcr.io/learnjs-174218/release'

0 commit comments

Comments
 (0)
Please sign in to comment.