Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine which dim results in the fastest CCL operation #2318

Open
tapspatel opened this issue Feb 27, 2025 · 0 comments
Open

Determine which dim results in the fastest CCL operation #2318

tapspatel opened this issue Feb 27, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@tapspatel
Copy link
Collaborator

Currently, when we decompose all_reduce into reduce_scatter and all_gather, we arbitrarily select a tensor dimension to do the split along. We find which dimension evenly divides by the number of devices along the cluster_axis we are performing the CCL on, and if no such tensor dim exists, we throw an error. We should select the tensor dim that results in the best performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant