Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add div op workaround #2350

Open
vladimirjovanovicTT opened this issue Mar 3, 2025 · 2 comments
Open

Add div op workaround #2350

vladimirjovanovicTT opened this issue Mar 3, 2025 · 2 comments
Assignees
Labels
MLIR Ops Issues related to MLIR dialect ops and their implementations

Comments

@vladimirjovanovicTT
Copy link
Contributor

Broadcast of non-commutative ops remains to be an issue in metal:
tenstorrent/tt-metal#14852

We are encountering this with div op in tt-xla:
tenstorrent/tt-xla#288

Since the op appears in backward pass of softmax op, this is essentially blocking us from training any classifier network.
In FFE, div op is being decomposed into reciprocal+multiply, which seems like a good solution here as well.
I suggest to introduce a workaround pass for this, where div is decomposed into reciprocal+multiply.

Some historical context:
#842

@vladimirjovanovicTT vladimirjovanovicTT added the MLIR Ops Issues related to MLIR dialect ops and their implementations label Mar 3, 2025
@vladimirjovanovicTT
Copy link
Contributor Author

Training crew would like to work on this; however we will try to push for the solution on metal first. Once we get an ETA from them, we will have a clearer picture on how/whether to continue.

@sdjordjevicTT
Copy link
Contributor

Training crew would like to work on this; however we will try to push for the solution on metal first. Once we get an ETA from them, we will have a clearer picture on how/whether to continue.

I will add here for the full context, that we are now pushing on the metal side this one:
tenstorrent/tt-metal#12798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MLIR Ops Issues related to MLIR dialect ops and their implementations
Projects
None yet
Development

No branches or pull requests

2 participants