Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimizer] Handle API error response when OpModel is turned off #2366

Open
3 tasks
rpavlovicTT opened this issue Mar 5, 2025 · 0 comments
Open
3 tasks
Assignees

Comments

@rpavlovicTT
Copy link
Contributor

Currently, when OpModel (controlled through build flag TTMLIR_ENABLE_OPMODEL) is OFF, all APIs for constraints will return tuple of zeros. Optimizer consumes this response and successfully finishes sharding. Some unit tests pass because of this. However, this is not fully correct behaviour.

With this in mind, we should:

  • Change API to throw an error when not implemented
  • Handle error response in Optimizer to stop compilation and throw an error
  • Sweep through Optimizer mlir unit tests that start breaking after handling API error response as suggested
@rpavlovicTT rpavlovicTT self-assigned this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant