Skip to content

Commit 84c1941

Browse files
authored
feat: Make validation timeout configurable (#124)
1 parent 3d9ddd9 commit 84c1941

File tree

4 files changed

+12
-0
lines changed

4 files changed

+12
-0
lines changed

README.md

+1
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ No modules.
210210
| <a name="input_validation_method"></a> [validation\_method](#input\_validation\_method) | Which method to use for validation. DNS or EMAIL are valid, NONE can be used for certificates that were imported into ACM and then into Terraform. | `string` | `"DNS"` | no |
211211
| <a name="input_validation_option"></a> [validation\_option](#input\_validation\_option) | The domain name that you want ACM to use to send you validation emails. This domain name is the suffix of the email addresses that you want ACM to use. | `any` | `{}` | no |
212212
| <a name="input_validation_record_fqdns"></a> [validation\_record\_fqdns](#input\_validation\_record\_fqdns) | When validation is set to DNS and the DNS validation records are set externally, provide the fqdns for the validation | `list(string)` | `[]` | no |
213+
| <a name="input_validation_timeout"></a> [validation\_timeout](#input\_validation\_timeout) | Define maximum timeout to wait for the validation to complete | `string` | `null` | no |
213214
| <a name="input_wait_for_validation"></a> [wait\_for\_validation](#input\_wait\_for\_validation) | Whether to wait for the validation to complete | `bool` | `true` | no |
214215
| <a name="input_zone_id"></a> [zone\_id](#input\_zone\_id) | The ID of the hosted zone to contain this record. Required when validating via Route53 | `string` | `""` | no |
215216

main.tf

+4
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,8 @@ resource "aws_acm_certificate_validation" "this" {
6666
certificate_arn = aws_acm_certificate.this[0].arn
6767

6868
validation_record_fqdns = flatten([aws_route53_record.validation[*].fqdn, var.validation_record_fqdns])
69+
70+
timeouts {
71+
create = var.validation_timeout
72+
}
6973
}

variables.tf

+6
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@ variable "wait_for_validation" {
2828
default = true
2929
}
3030

31+
variable "validation_timeout" {
32+
description = "Define maximum timeout to wait for the validation to complete"
33+
type = string
34+
default = null
35+
}
36+
3137
variable "certificate_transparency_logging_preference" {
3238
description = "Specifies whether certificate details should be added to a certificate transparency log"
3339
type = bool

wrappers/main.tf

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ module "wrapper" {
88
validate_certificate = try(each.value.validate_certificate, var.defaults.validate_certificate, true)
99
validation_allow_overwrite_records = try(each.value.validation_allow_overwrite_records, var.defaults.validation_allow_overwrite_records, true)
1010
wait_for_validation = try(each.value.wait_for_validation, var.defaults.wait_for_validation, true)
11+
validation_timeout = try(each.value.validation_timeout, var.defaults.validation_timeout, null)
1112
certificate_transparency_logging_preference = try(each.value.certificate_transparency_logging_preference, var.defaults.certificate_transparency_logging_preference, true)
1213
domain_name = try(each.value.domain_name, var.defaults.domain_name, "")
1314
subject_alternative_names = try(each.value.subject_alternative_names, var.defaults.subject_alternative_names, [])

0 commit comments

Comments
 (0)