From 40b8d19c96a56b466e7f6d488d00468e26169ba5 Mon Sep 17 00:00:00 2001 From: Seth Eliot Date: Tue, 11 Feb 2025 08:52:42 -0800 Subject: [PATCH 1/7] Add ALB endpoint to outputs - this makes it easier to test for successful deployment --- examples/ec2-autoscaling/README.md | 1 + examples/ec2-autoscaling/outputs.tf | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/examples/ec2-autoscaling/README.md b/examples/ec2-autoscaling/README.md index c7a04afc..4428f23f 100644 --- a/examples/ec2-autoscaling/README.md +++ b/examples/ec2-autoscaling/README.md @@ -61,6 +61,7 @@ No inputs. | Name | Description | |------|-------------| +| [alb\_dns\_name](#output\_alb\_dns) | DNS endpoint for the Application Load Balancer (ALB) | | [cluster\_arn](#output\_cluster\_arn) | ARN that identifies the cluster | | [cluster\_autoscaling\_capacity\_providers](#output\_cluster\_autoscaling\_capacity\_providers) | Map of capacity providers created and their attributes | | [cluster\_capacity\_providers](#output\_cluster\_capacity\_providers) | Map of cluster capacity providers attributes | diff --git a/examples/ec2-autoscaling/outputs.tf b/examples/ec2-autoscaling/outputs.tf index 2f6f85a7..d1e801c9 100644 --- a/examples/ec2-autoscaling/outputs.tf +++ b/examples/ec2-autoscaling/outputs.tf @@ -130,3 +130,13 @@ output "service_autoscaling_scheduled_actions" { description = "Map of autoscaling scheduled actions and their attributes" value = module.ecs_service.autoscaling_scheduled_actions } + +################################################################################ +# Application Load Balancer +################################################################################ + + +output "alb_dns_name" { + description = "ALB endpoint DNS" + value = module.alb.dns_name +} \ No newline at end of file From c9c01b9d459c9fd4cd90b6a07da34a920191bce2 Mon Sep 17 00:00:00 2001 From: Seth Eliot Date: Tue, 11 Feb 2025 09:04:53 -0800 Subject: [PATCH 2/7] fix trailing whitespace --- examples/ec2-autoscaling/outputs.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ec2-autoscaling/outputs.tf b/examples/ec2-autoscaling/outputs.tf index d1e801c9..524bf572 100644 --- a/examples/ec2-autoscaling/outputs.tf +++ b/examples/ec2-autoscaling/outputs.tf @@ -139,4 +139,4 @@ output "service_autoscaling_scheduled_actions" { output "alb_dns_name" { description = "ALB endpoint DNS" value = module.alb.dns_name -} \ No newline at end of file +} From bbd7ae277c2458692e729db171362b0e7e78636e Mon Sep 17 00:00:00 2001 From: Seth Eliot Date: Tue, 11 Feb 2025 09:08:42 -0800 Subject: [PATCH 3/7] update README to conform with conventions --- examples/ec2-autoscaling/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ec2-autoscaling/README.md b/examples/ec2-autoscaling/README.md index 4428f23f..1fe2d9a7 100644 --- a/examples/ec2-autoscaling/README.md +++ b/examples/ec2-autoscaling/README.md @@ -61,7 +61,7 @@ No inputs. | Name | Description | |------|-------------| -| [alb\_dns\_name](#output\_alb\_dns) | DNS endpoint for the Application Load Balancer (ALB) | +| [alb\_dns\_name](#output\_alb\_dns\_name) | ALB endpoint DNS | | [cluster\_arn](#output\_cluster\_arn) | ARN that identifies the cluster | | [cluster\_autoscaling\_capacity\_providers](#output\_cluster\_autoscaling\_capacity\_providers) | Map of capacity providers created and their attributes | | [cluster\_capacity\_providers](#output\_cluster\_capacity\_providers) | Map of cluster capacity providers attributes | From 9fc012731de648a85d7b997a77c20eccd8f3d9fe Mon Sep 17 00:00:00 2001 From: Seth Eliot Date: Wed, 12 Feb 2025 15:22:58 -0800 Subject: [PATCH 4/7] Add ALB endpoint to outputs - this makes it easier to test for successful deployment --- examples/complete/README.md | 1 + examples/complete/outputs.tf | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/examples/complete/README.md b/examples/complete/README.md index 3f105953..66f5d1b4 100644 --- a/examples/complete/README.md +++ b/examples/complete/README.md @@ -62,6 +62,7 @@ No inputs. | Name | Description | |------|-------------| +| [alb\_dns\_name](#output\_alb\_dns\_name) | ALB endpoint DNS | | [cluster\_arn](#output\_cluster\_arn) | ARN that identifies the cluster | | [cluster\_autoscaling\_capacity\_providers](#output\_cluster\_autoscaling\_capacity\_providers) | Map of capacity providers created and their attributes | | [cluster\_capacity\_providers](#output\_cluster\_capacity\_providers) | Map of cluster capacity providers attributes | diff --git a/examples/complete/outputs.tf b/examples/complete/outputs.tf index 35031694..4482b2c6 100644 --- a/examples/complete/outputs.tf +++ b/examples/complete/outputs.tf @@ -35,3 +35,12 @@ output "services" { description = "Map of services created and their attributes" value = module.ecs.services } + +################################################################################ +# Application Load Balancer +################################################################################ + +output "alb_dns_name" { + description = "ALB endpoint DNS" + value = module.alb.dns_name +} \ No newline at end of file From 3dfd85825b92056aa5d2763a620f92c51637e01e Mon Sep 17 00:00:00 2001 From: Seth Eliot Date: Wed, 12 Feb 2025 15:25:17 -0800 Subject: [PATCH 5/7] EOF fix --- examples/complete/outputs.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/complete/outputs.tf b/examples/complete/outputs.tf index 4482b2c6..8f4fb346 100644 --- a/examples/complete/outputs.tf +++ b/examples/complete/outputs.tf @@ -43,4 +43,4 @@ output "services" { output "alb_dns_name" { description = "ALB endpoint DNS" value = module.alb.dns_name -} \ No newline at end of file +} From 397946ff00e1688c4c34326db95379b13f534f0e Mon Sep 17 00:00:00 2001 From: Seth Eliot Date: Fri, 7 Mar 2025 10:06:27 -0800 Subject: [PATCH 6/7] updates in response to bryantbiggs review --- examples/complete/outputs.tf | 2 +- examples/ec2-autoscaling/outputs.tf | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/examples/complete/outputs.tf b/examples/complete/outputs.tf index 8f4fb346..dd0cdd27 100644 --- a/examples/complete/outputs.tf +++ b/examples/complete/outputs.tf @@ -41,6 +41,6 @@ output "services" { ################################################################################ output "alb_dns_name" { - description = "ALB endpoint DNS" + description = "The DNS name of the load balancer" value = module.alb.dns_name } diff --git a/examples/ec2-autoscaling/outputs.tf b/examples/ec2-autoscaling/outputs.tf index 524bf572..80903ad5 100644 --- a/examples/ec2-autoscaling/outputs.tf +++ b/examples/ec2-autoscaling/outputs.tf @@ -135,8 +135,7 @@ output "service_autoscaling_scheduled_actions" { # Application Load Balancer ################################################################################ - output "alb_dns_name" { - description = "ALB endpoint DNS" + description = "The DNS name of the load balancer" value = module.alb.dns_name } From fce632b8f5fb7e4361bdce05525e97fbbd1c4c13 Mon Sep 17 00:00:00 2001 From: Seth Eliot Date: Fri, 7 Mar 2025 12:41:30 -0800 Subject: [PATCH 7/7] docs updates to go with CR feedback --- examples/complete/README.md | 2 +- examples/ec2-autoscaling/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/complete/README.md b/examples/complete/README.md index 66f5d1b4..9d20e63d 100644 --- a/examples/complete/README.md +++ b/examples/complete/README.md @@ -62,7 +62,7 @@ No inputs. | Name | Description | |------|-------------| -| [alb\_dns\_name](#output\_alb\_dns\_name) | ALB endpoint DNS | +| [alb\_dns\_name](#output\_alb\_dns\_name) | The DNS name of the load balancer | | [cluster\_arn](#output\_cluster\_arn) | ARN that identifies the cluster | | [cluster\_autoscaling\_capacity\_providers](#output\_cluster\_autoscaling\_capacity\_providers) | Map of capacity providers created and their attributes | | [cluster\_capacity\_providers](#output\_cluster\_capacity\_providers) | Map of cluster capacity providers attributes | diff --git a/examples/ec2-autoscaling/README.md b/examples/ec2-autoscaling/README.md index 1fe2d9a7..ff7a998d 100644 --- a/examples/ec2-autoscaling/README.md +++ b/examples/ec2-autoscaling/README.md @@ -61,7 +61,7 @@ No inputs. | Name | Description | |------|-------------| -| [alb\_dns\_name](#output\_alb\_dns\_name) | ALB endpoint DNS | +| [alb\_dns\_name](#output\_alb\_dns\_name) | The DNS name of the load balancer | | [cluster\_arn](#output\_cluster\_arn) | ARN that identifies the cluster | | [cluster\_autoscaling\_capacity\_providers](#output\_cluster\_autoscaling\_capacity\_providers) | Map of capacity providers created and their attributes | | [cluster\_capacity\_providers](#output\_cluster\_capacity\_providers) | Map of cluster capacity providers attributes |