fix: Update CI configuration files to use latest version (#43)

bryantbiggs · web-flow · commit 9eea3d9cf7c3 · 2022-10-27T20:34:22.000+02:00
diff --git a/.github/workflows/lock.yml b/.github/workflows/lock.yml
@@ -0,0 +1,21 @@
+name: 'Lock Threads'
+
+on:
+  schedule:
+    - cron: '50 1 * * *'
+
+jobs:
+  lock:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: dessant/lock-threads@v3
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          issue-comment: >
+            I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.
+            If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
+          issue-inactive-days: '30'
+          pr-comment: >
+            I'm going to lock this pull request because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.
+            If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
+          pr-inactive-days: '30'
diff --git a/.github/workflows/pr-title.yml b/.github/workflows/pr-title.yml
@@ -14,7 +14,7 @@ jobs:
     steps:
       # Please look up the latest version from
       # https://github.com/amannn/action-semantic-pull-request/releases
-      - uses: amannn/action-semantic-pull-request@v3.4.6
+      - uses: amannn/action-semantic-pull-request@v5.0.2
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml
@@ -17,11 +17,11 @@ jobs:
       directories: ${{ steps.dirs.outputs.directories }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Get root directories
         id: dirs
-        uses: clowdhaus/terraform-composite-actions/directories@v1.3.0
+        uses: clowdhaus/terraform-composite-actions/directories@v1.8.0
 
   preCommitMinVersions:
     name: Min TF pre-commit
@@ -32,26 +32,26 @@ jobs:
         directory: ${{ fromJson(needs.collectInputs.outputs.directories) }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Terraform min/max versions
         id: minMax
-        uses: clowdhaus/terraform-min-max@v1.0.3
+        uses: clowdhaus/terraform-min-max@v1.2.0
         with:
           directory: ${{ matrix.directory }}
 
       - name: Pre-commit Terraform ${{ steps.minMax.outputs.minVersion }}
         # Run only validate pre-commit check on min version supported
         if: ${{ matrix.directory !=  '.' }}
-        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.3.0
+        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.8.0
         with:
           terraform-version: ${{ steps.minMax.outputs.minVersion }}
           args: 'terraform_validate --color=always --show-diff-on-failure --files ${{ matrix.directory }}/*'
 
       - name: Pre-commit Terraform ${{ steps.minMax.outputs.minVersion }}
         # Run only validate pre-commit check on min version supported
         if: ${{ matrix.directory ==  '.' }}
-        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.3.0
+        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.8.0
         with:
           terraform-version: ${{ steps.minMax.outputs.minVersion }}
           args: 'terraform_validate --color=always --show-diff-on-failure --files $(ls *.tf)'
@@ -62,17 +62,17 @@ jobs:
     needs: collectInputs
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref: ${{ github.event.pull_request.head.ref }}
           repository: ${{github.event.pull_request.head.repo.full_name}}
 
       - name: Terraform min/max versions
         id: minMax
-        uses: clowdhaus/terraform-min-max@v1.0.3
+        uses: clowdhaus/terraform-min-max@v1.2.0
 
       - name: Pre-commit Terraform ${{ steps.minMax.outputs.maxVersion }}
-        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.3.0
+        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.8.0
         with:
           terraform-version: ${{ steps.minMax.outputs.maxVersion }}
           terraform-docs-version: ${{ env.TERRAFORM_DOCS_VERSION }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -20,7 +20,7 @@ jobs:
     if: github.repository_owner == 'terraform-aws-modules'
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           persist-credentials: false
           fetch-depth: 0
diff --git a/.github/workflows/stale-actions.yaml b/.github/workflows/stale-actions.yaml
@@ -7,7 +7,7 @@ jobs:
   stale:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@v4
+      - uses: actions/stale@v6
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           # Staling issues and PR's
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.62.3
+    rev: v1.76.0
     hooks:
       - id: terraform_fmt
       - id: terraform_validate
@@ -23,7 +23,7 @@ repos:
           - '--args=--only=terraform_standard_module_structure'
           - '--args=--only=terraform_workspace_remote'
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.1.0
+    rev: v4.3.0
     hooks:
       - id: check-merge-conflict
       - id: end-of-file-fixer
diff --git a/README.md b/README.md
@@ -165,6 +165,7 @@ No modules.
 | [aws_iam_role_policy_attachment.additional_many](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
 | [aws_iam_role_policy_attachment.additional_one](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
 | [aws_sfn_state_machine.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sfn_state_machine) | resource |
+| [aws_caller_identity.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/caller_identity) | data source |
 | [aws_cloudwatch_log_group.sfn](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/cloudwatch_log_group) | data source |
 | [aws_iam_policy_document.additional_inline](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document) | data source |
 | [aws_iam_policy_document.assume_role](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document) | data source |
diff --git a/examples/complete/main.tf b/examples/complete/main.tf
@@ -67,7 +67,7 @@ module "step_function" {
     }
 
     stepfunction_Sync = {
-      stepfunction = ["arn:aws:states:eu-west-1:123456789012:stateMachine:test1"]
+      stepfunction          = ["arn:aws:states:eu-west-1:123456789012:stateMachine:test1"]
       stepfunction_Wildcard = ["arn:aws:states:eu-west-1:123456789012:stateMachine:test1"]
 
       # Set to true to use the default events (otherwise, set this to a list of ARNs; see the docs linked in locals.tf
diff --git a/main.tf b/main.tf
@@ -7,7 +7,7 @@ locals {
   enable_xray_tracing = try(var.service_integrations["xray"]["xray"], false) == true
 
   # Normalize ARN by trimming ":*" because data-source has it, but resource does not have it
-  log_group_arn = trimsuffix(element(concat(data.aws_cloudwatch_log_group.sfn.*.arn, aws_cloudwatch_log_group.sfn.*.arn, [""]), 0), ":*")
+  log_group_arn = trimsuffix(try(data.aws_cloudwatch_log_group.sfn[0].arn, aws_cloudwatch_log_group.sfn[0].arn, ""), ":*")
 
   role_name = local.create_role ? coalesce(var.role_name, var.name) : null
 }
diff --git a/outputs.tf b/outputs.tf
@@ -1,31 +1,31 @@
 # Step Function
 output "state_machine_id" {
   description = "The ARN of the Step Function"
-  value       = element(concat(aws_sfn_state_machine.this.*.id, [""]), 0)
+  value       = try(aws_sfn_state_machine.this[0].id, "")
 }
 
 output "state_machine_arn" {
   description = "The ARN of the Step Function"
-  value       = element(concat(aws_sfn_state_machine.this.*.arn, [""]), 0)
+  value       = try(aws_sfn_state_machine.this[0].arn, "")
 }
 
 output "state_machine_creation_date" {
   description = "The date the Step Function was created"
-  value       = element(concat(aws_sfn_state_machine.this.*.creation_date, [""]), 0)
+  value       = try(aws_sfn_state_machine.this[0].creation_date, "")
 }
 
 output "state_machine_status" {
   description = "The current status of the Step Function"
-  value       = element(concat(aws_sfn_state_machine.this.*.status, [""]), 0)
+  value       = try(aws_sfn_state_machine.this[0].status, "")
 }
 
 # IAM Role
 output "role_arn" {
   description = "The ARN of the IAM role created for the Step Function"
-  value       = element(concat(aws_iam_role.this.*.arn, [""]), 0)
+  value       = try(aws_iam_role.this[0].arn, "")
 }
 
 output "role_name" {
   description = "The name of the IAM role created for the Step Function"
-  value       = element(concat(aws_iam_role.this.*.name, [""]), 0)
+  value       = try(aws_iam_role.this[0].name, "")
 }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ module "step_function" {`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`stepfunction_Sync = {`
`70`		`- stepfunction = ["arn:aws:states:eu-west-1:123456789012:stateMachine:test1"]`
	`70`	`+ stepfunction = ["arn:aws:states:eu-west-1:123456789012:stateMachine:test1"]`
`71`	`71`	`stepfunction_Wildcard = ["arn:aws:states:eu-west-1:123456789012:stateMachine:test1"]`
`72`	`72`
`73`	`73`	`# Set to true to use the default events (otherwise, set this to a list of ARNs; see the docs linked in locals.tf`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ locals {`
`7`	`7`	`enable_xray_tracing = try(var.service_integrations["xray"]["xray"], false) == true`
`8`	`8`
`9`	`9`	`# Normalize ARN by trimming ":*" because data-source has it, but resource does not have it`
`10`		`- log_group_arn = trimsuffix(element(concat(data.aws_cloudwatch_log_group.sfn..arn, aws_cloudwatch_log_group.sfn..arn, [""]), 0), ":*")`
	`10`	`+ log_group_arn = trimsuffix(try(data.aws_cloudwatch_log_group.sfn[0].arn, aws_cloudwatch_log_group.sfn[0].arn, ""), ":*")`
`11`	`11`
`12`	`12`	`role_name = local.create_role ? coalesce(var.role_name, var.name) : null`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,31 +1,31 @@`
`1`	`1`	`# Step Function`
`2`	`2`	`output "state_machine_id" {`
`3`	`3`	`description = "The ARN of the Step Function"`
`4`		`- value = element(concat(aws_sfn_state_machine.this.*.id, [""]), 0)`
	`4`	`+ value = try(aws_sfn_state_machine.this[0].id, "")`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`output "state_machine_arn" {`
`8`	`8`	`description = "The ARN of the Step Function"`
`9`		`- value = element(concat(aws_sfn_state_machine.this.*.arn, [""]), 0)`
	`9`	`+ value = try(aws_sfn_state_machine.this[0].arn, "")`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`output "state_machine_creation_date" {`
`13`	`13`	`description = "The date the Step Function was created"`
`14`		`- value = element(concat(aws_sfn_state_machine.this.*.creation_date, [""]), 0)`
	`14`	`+ value = try(aws_sfn_state_machine.this[0].creation_date, "")`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`output "state_machine_status" {`
`18`	`18`	`description = "The current status of the Step Function"`
`19`		`- value = element(concat(aws_sfn_state_machine.this.*.status, [""]), 0)`
	`19`	`+ value = try(aws_sfn_state_machine.this[0].status, "")`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`# IAM Role`
`23`	`23`	`output "role_arn" {`
`24`	`24`	`description = "The ARN of the IAM role created for the Step Function"`
`25`		`- value = element(concat(aws_iam_role.this.*.arn, [""]), 0)`
	`25`	`+ value = try(aws_iam_role.this[0].arn, "")`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`output "role_name" {`
`29`	`29`	`description = "The name of the IAM role created for the Step Function"`
`30`		`- value = element(concat(aws_iam_role.this.*.name, [""]), 0)`
	`30`	`+ value = try(aws_iam_role.this[0].name, "")`
`31`	`31`	`}`