Skip to content

Commit 38f7aa2

Browse files
Gary Hadetorvalds
Gary Hade
authored andcommitted
matroxfb: remove incorrect Matrox G200eV support
Remove incorrect Matrox G200eV support that was previously added by commit e3a1938 A serious issue with the incorrect G200eV support that reproduces on the Matrox G200eV equipped IBM x3650 M2 is the total lack of text (login banner, login prompt, etc) on the console when X is not running and total lack of text on all of the virtual consoles after X is started. Any concerns that the incorrect code (upstream since October 2008) has been successfully used on non-IBM G200eV equipped system(s) appear to be unwarranted. In addition to the serious/non-intermittent nature of issues that have been spotted on IBM systems, complete removal of the incorrect code is clearly supported by the following Matrox (Yannick Heneault) provided input: "It impossible that this patch should have work on a system. The patch only declare the G200eV as a regular G200 which is not case. Many registers are different, including at least the PLL programming sequence. If the G200eV is programmed like a regular G200, it will not display anything." v1 - Initial patch that removed the incorrect code for _all_ G200eV equipped systems. v2 - Darrick Wong provided patch that blacklisted the incorrect code on G200eV equipped IBM systems leaving it enabled on all G200eV equipped non-IBM systems. v3 - Same code changes included with v1 plus additional justification for complete removal of the incorrect code. Signed-off-by: Gary Hade <[email protected]> Cc: Darrick J. Wong <[email protected]> Cc: Krzysztof Helt <[email protected]> Cc: Petr Vandrovec <[email protected]> Cc: Andrew Morton <[email protected]> Cc: Linus Torvalds <[email protected]> Cc: Yannick Heneault <[email protected]> Cc: Christian Toutant <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 3155fe6 commit 38f7aa2

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

drivers/video/matrox/matroxfb_base.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1461,13 +1461,6 @@ static struct board {
14611461
MGA_G100,
14621462
&vbG100,
14631463
"MGA-G100 (AGP)"},
1464-
{PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G200EV_PCI, 0xFF,
1465-
0, 0,
1466-
DEVF_G200,
1467-
230000,
1468-
MGA_G200,
1469-
&vbG200,
1470-
"MGA-G200eV (PCI)"},
14711464
{PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G200_PCI, 0xFF,
14721465
0, 0,
14731466
DEVF_G200,
@@ -2119,8 +2112,6 @@ static struct pci_device_id matroxfb_devices[] = {
21192112
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
21202113
{PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G100_AGP,
21212114
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
2122-
{PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G200EV_PCI,
2123-
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
21242115
{PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G200_PCI,
21252116
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
21262117
{PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G200_AGP,

0 commit comments

Comments
 (0)