regulator: max8952 - fix max8952_set_voltage

AxelLin · Liam Girdwood · commit ec10b0e94ebe · 2010-10-28T22:40:32.000+01:00
In current implementation, vid is declared as u8,
then "vid == -1" is always false, and "vid &gt;= 0" is always true.
Thus change it to s8.

Signed-off-by: Axel Lin &lt;axel.lin@gmail.com&gt;
Acked-by: Mark Brown &lt;broonie@opensource.wolfsonmicro.com&gt;
Acked-by: Kyungmin Park &lt;kyungmin.park@samsung.com&gt;
Signed-off-by: Liam Girdwood &lt;lrg@slimlogic.co.uk&gt;
diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c
@@ -136,7 +136,7 @@ static int max8952_set_voltage(struct regulator_dev *rdev,
 				int min_uV, int max_uV)
 {
 	struct max8952_data *max8952 = rdev_get_drvdata(rdev);
-	u8 vid = -1, i;
+	s8 vid = -1, i;
 
 	if (!gpio_is_valid(max8952->pdata->gpio_vid0) ||
 			!gpio_is_valid(max8952->pdata->gpio_vid0)) {

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ static int max8952_set_voltage(struct regulator_dev *rdev,`
`136`	`136`	`int min_uV, int max_uV)`
`137`	`137`	`{`
`138`	`138`	`struct max8952_data *max8952 = rdev_get_drvdata(rdev);`
`139`		`- u8 vid = -1, i;`
	`139`	`+ s8 vid = -1, i;`
`140`	`140`
`141`	`141`	`if (!gpio_is_valid(max8952->pdata->gpio_vid0) \|\|`
`142`	`142`	`!gpio_is_valid(max8952->pdata->gpio_vid0)) {`