Raising error in invalid xsTypeNum condition (#2042)

Author: ntouran

armi/physics/neutronics/crossSectionGroupManager.py

@@ -95,7 +95,7 @@ def getXSTypeNumberFromLabel(xsTypeLabel: str) -> int:
     return int("".join(["{:02d}".format(ord(si)) for si in xsTypeLabel]))
 
 
-def getXSTypeLabelFromNumber(xsTypeNumber: int) -> int:
+def getXSTypeLabelFromNumber(xsTypeNumber: int) -> str:
     """
     Convert a XSID label (e.g. 65) to an XS label (e.g. 'A').
 
@@ -107,6 +107,11 @@ def getXSTypeLabelFromNumber(xsTypeNumber: int) -> int:
         if xsTypeNumber > ord("Z"):
             # two digit. Parse
             return chr(int(str(xsTypeNumber)[:2])) + chr(int(str(xsTypeNumber)[2:]))
+        elif xsTypeNumber < ord("A"):
+            raise ValueError(
+                f"Cannot convert invalid xsTypeNumber `{xsTypeNumber}` to char. "
+                "The number must be >= 65 (corresponding to 'A')."
+            )
         else:
             return chr(xsTypeNumber)
     except ValueError:

armi/reactor/tests/test_assemblies.py

@@ -219,7 +219,7 @@ def setUp(self):
             "residence": 4.0,
             "smearDensity": 0.6996721711791459,
             "timeToLimit": 2.7e5,
-            "xsTypeNum": 40,
+            "xsTypeNum": 65,
             "zbottom": 97.3521,
             "ztop": 111.80279999999999,
         }
@@ -776,9 +776,9 @@ def test_calcTotalParam(self):
             # Set the 1st block to have higher params than the rest.
             self.blockParamsTemp = {}
             for key, val in self.blockParams.items():
-                b.p[key] = self.blockParamsTemp[key] = (
-                    val * i
-                )  # Iterate with i in self.assemNum, so higher assemNums get the high values.
+                # Iterate with i in self.assemNum, so higher assemNums get the high values.
+                if key != "xsTypeNum":  # must keep valid
+                    b.p[key] = self.blockParamsTemp[key] = val * i
 
             b.setHeight(self.height)
             b.setType("fuel")

armi/utils/tests/test_reportPlotting.py

@@ -118,8 +118,8 @@ def test_xsHistoryVsTime(self):
         class HistTester:
             def __init__(self):
                 self.xsHistory = {
-                    1: [[0, 1], [0, 2], [0, 3]],
-                    2: [[0, 5], [0, 6], [0, 7]],
+                    65: [[0, 1], [0, 2], [0, 3]],
+                    66: [[0, 5], [0, 6], [0, 7]],
                 }
 
         history = HistTester()