Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary isotopicDepletion stub #1458

Closed
keckler opened this issue Nov 2, 2023 · 3 comments · Fixed by #1671
Closed

Remove unnecessary isotopicDepletion stub #1458

keckler opened this issue Nov 2, 2023 · 3 comments · Fixed by #1671
Assignees
Labels
cleanup Code/comment cleanup: Low Priority low priority Style points and non-features

Comments

@keckler
Copy link
Member

keckler commented Nov 2, 2023

This file is not useful. If a user wants to use the STACK_ORDER.DEPLETION constant, they can just use it directly from the interfaces module. None of the other imports in this file are used.

"""The depletion physics package contains utility/framework code related to the physics of transmutation and decay."""
# ruff: noqa: F401
import os
from armi import RES
from armi.nucDirectory import nuclideBases
from armi import interfaces
ORDER = interfaces.STACK_ORDER.DEPLETION

Unfortunately we have an internal plugin that directly imports ORDER from here. So we can't just delete this. But it should be slated for removal.

@keckler keckler added cleanup Code/comment cleanup: Low Priority low priority Style points and non-features labels Nov 2, 2023
@keckler
Copy link
Member Author

keckler commented Nov 17, 2023

Same goes for the stub in latticePhysics:

"""Initialization of the interfaces for running lattice physics calculations."""
# ruff: noqa: F401
import os
from armi import interfaces
from armi import settings
from armi.physics import neutronics
from armi.utils import pathTools
ORDER = interfaces.STACK_ORDER.CROSS_SECTIONS

EDIT: This will go away if #1479 is merged.

@john-science
Copy link
Member

@keckler @albeanth

Okay, I understand this file is mostly empty. And I would like to remove it.

I can only find one place where this stub is used downstream, and I have opened a ticket there. When THAT is cleaned up, we can happily remove this stub.

@john-science
Copy link
Member

@keckler As we are going to move the entire latticePhysics package out of ARMI, I am not so concerned about the second stub you mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority low priority Style points and non-features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants