-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of new act warnings since 9.3.1 #1251
Comments
Hi @jgarplind, thanks for opening this. |
Thanks for getting back so soon. Right, of course Before closing, I just wanted to mention the error that I have worked around by simplifying the test, but which was also caused by the 9.3.0 -> 9.3.1 upgrade:
Now, this is just one test, and it is non-trivial (including usage of mswjs.io, zod, etc.), but I was still surprised to see it stop working all out of sudden:
I suppose this doesn't change much - the issue is better handled where you linked me to, but now at least I have shared most of the information available to me! |
Then again.. I've been on |
The point is |
You can see in my initial post that it was the same (5.1.3) which just causes me even more confusion. But I can consistently "toggle" the warnings just by flipping between 9.3.0 and 9.3.1. ... and when cross-checking again (after playing around a bit with pnpm hooks and whatnot), I now see a different version for 9.3.0, namely [email protected]:
I'm really stumped, but for now I think I will just enforce 9.3.0 using a pnpm hook*, since I believe (and hope for) these warnings to be misplaced. *For anyone interested, looks like this:
as explained here: https://pnpm.io/pnpmfile#hooksreadpackagepkg-context-pkg--promisepkg |
I'm experiencing the very same issue. I'm using |
Just updated to the latest releases of this package as well as Closing. |
Turns out the issue is with multiple versions. It hit us again now with So indeed the original tip to check testing-library/react-testing-library#1216 was relevant, since that discussion has now turned us there. |
@testing-library/dom
version: 9.3.1Relevant code or config:
What you did:
Re-installed packages for the first time since
@testing-library/[email protected]
was released, triggering an upgrade since I use@testing-library/user-event
which has a peer dependency:"@testing-library/dom": ">=7.21.4"
This is the different in my
pnpm-lock.yaml
:What happened:
New behaviors, including errors and warnings.
In particular, a lot of new act warnings:
It is really quite pervasive, and could be due to user error, but I am a fairly experience testing library user and have never seen anything like this.
Reproduction:
Seeking to understand if I am being reasonable or barking up the wrong tree before spending time on that, sorry.
Problem description:
Our trust in our tests is significantly reduced since the warnings indicate that they don't operate correctly.
Suggested solution:
Help me understand how 9.3.1, really only pinning
aria-query
to a slightly older version, could cause all this trouble?The text was updated successfully, but these errors were encountered: