-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppeteer v17 compatibility #77
Comments
The new recommended approach in v17.1.0 is to use |
Thanks for the note @swissspidy! We'll fix it 👍 |
fix is up at #78 but getting this to work in a non-breaking way with typescript is...tricky :) help with tests is welcome |
Is there any update on this? If getting the types to work on both new and old versions of puppeteer is too much hassle, could the solution not be to drop support for old versions of puppeteer and release the changes as a major version bump? |
fixed by #78 |
In puppeteer/puppeteer#8844, which was released as part of Puppeteer v17, the execution context has been marked internal, so this access is no longer possible.
I see it's being used twice here:
pptr-testing-library/lib/index.ts
Line 92 in 860106b
pptr-testing-library/lib/index.ts
Line 101 in 860106b
The text was updated successfully, but these errors were encountered: