Skip to content

Commit 7a954f1

Browse files
committed
test: Run with relevant React stable types
This has no effect right now. Once React 19 is out, we're running tests in both 18 and 19. The types should match that dimension. Ideally, we'd be able to test RC types but npm claims `npm install @types/react@npm:types-react@rc` is an invalid comparator. Putting that in the package.json works but I'm too lazy to write a dedicated script right now.
1 parent a4744fa commit 7a954f1

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

Diff for: .github/workflows/validate.yml

+6
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ jobs:
5555
- name: ⚛️ Setup react
5656
run: npm install react@${{ matrix.react }} react-dom@${{ matrix.react }}
5757

58+
- name: ⚛️ Setup react types
59+
if: ${{ matrix.react != 'canary' && matrix.react != 'experimental' }}
60+
run:
61+
npm install @types/react@${{ matrix.react }} @types/react-dom@${{
62+
matrix.react }}
63+
5864
- name: ▶️ Run validate script
5965
run: npm run validate
6066

0 commit comments

Comments
 (0)