Skip to content

Commit deb0140

Browse files
committed
Optimize view exercise page
1 parent 8d4e216 commit deb0140

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

app/controllers/exercises_controller.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ def show
1919

2020
@submissions = @submissions.where(user_id: current_user.id) unless can? :teach, @course
2121
@submissions = @submissions.includes(:awarded_points).includes(:user).includes(:course)
22-
@submission_count = @submissions.count
2322
@submissions = @submissions.limit(50) unless !!params[:view_all]
2423
else
2524
@submissions = nil

app/views/exercises/show.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,8 @@
180180
<div class="col-md-12">
181181
<h2>Submissions</h2>
182182
<% if !@submissions.empty? %>
183-
<% if @submissions.size < @submission_count %>
184-
<p>Showing <%= @submissions.size%> of <%= @submission_count %> submissions. <%= link_to "View all submissions", exercise_path(@exercise, view_all: 1) %></p>
183+
<% if @submissions.size == 50 %>
184+
<p>Showing only 50 submissions. <%= link_to "View all submissions", exercise_path(@exercise, view_all: 1) %></p>
185185
<% end %>
186186
<%= show_submission_list(@submissions, :show_exercise_column => false, :show_awarded_points => true) %>
187187
<% else %>

0 commit comments

Comments
 (0)