Skip to content

Commit 46a6ddc

Browse files
authored
Fix downloadscript for istioctl for 1.10+ (#60)
Signed-off-by: Takeshi Yoneda <[email protected]>
1 parent 5a4c18e commit 46a6ddc

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

.github/workflows/workflow.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ jobs:
9595
e2e-test:
9696
strategy:
9797
matrix:
98-
os: [ ubuntu-latest ] # TODO: once kind is available for macos, test against it
98+
os: [ ubuntu-latest ]
9999
name: e2e test
100100
runs-on: ${{ matrix.os }}
101101
steps:
@@ -107,8 +107,10 @@ jobs:
107107
with:
108108
go-version: 1.16.5
109109

110-
- name: setup kind cluster
111-
uses: engineerd/[email protected]
110+
- uses: debianmaster/actions-k3s@master
111+
id: k3s
112+
with:
113+
version: 'v1.21.2-k3s1'
112114

113115
- uses: actions/cache@v2
114116
with:

src/istioctl/donwload_script.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,7 @@ ARCH_SUPPORTED=$(echo "$ISTIO_VERSION" | awk '{ ARCH_SUPPORTED=substr($0, 1, 3)
8888
ARCH_UNSUPPORTED="1.5"
8989
9090
if [ "${OS}" = "Linux" ] ; then
91-
# This checks if 1.6 <= 1.5 or 1.4 <= 1.5
92-
if [ "$(expr "${ARCH_SUPPORTED}" \<= "${ARCH_UNSUPPORTED}")" -eq 1 ]; then
93-
without_arch
94-
else
95-
with_arch
96-
fi
91+
with_arch
9792
elif [ "x${OS}" = "xDarwin" ] ; then
9893
without_arch
9994
else

0 commit comments

Comments
 (0)