You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Arose in #32 where I couldn’t understand while testing why requesting a bundle embed wasn’t working (it’s called bundles with an s).
In this case and maybe others we should consider adding an alternative interface based on Python objects where you get some kind of error when you misspell their names. (In the case of embeds the string-based interface is fine as a lower-level alternative which allows more flexibility in case e.g. upstream DSpace ever adds more embed types)
The text was updated successfully, but these errors were encountered:
We might even be able to come up with a generator to parse the REST server java and at least give us some enums/constants/maps to work with initially....
I think the linked PR for this comment is actually supposed to be #20 - it's true that search configs for #32 do use literal strings like 'default' but they are user-defined in XML config on the backend, so not something that we can really solve with enums (unlike modelling, types, etc which i agree we should solve with enums)
Arose in #32 where I couldn’t understand while testing why requesting a
bundle
embed wasn’t working (it’s calledbundles
with an s).In this case and maybe others we should consider adding an alternative interface based on Python objects where you get some kind of error when you misspell their names. (In the case of embeds the string-based interface is fine as a lower-level alternative which allows more flexibility in case e.g. upstream DSpace ever adds more embed types)
The text was updated successfully, but these errors were encountered: