Fix typos

peter-wangxu · peter-wangxu · commit 9eec4f8b0254 · 2017-10-26T09:51:16.000+08:00
Remove typos found during review.
diff --git a/README.md b/README.md
@@ -92,22 +92,22 @@ puppet module install ".\dellemc-unity-x.y.z.tar.gz"
 * Define a managed Unity system
 
 ```puppet
-unity_system { 'FNM00150600267':
-  ip       => '10.245.101.39',
+unity_system { 'FNM12345678901':
+  ip       => '192.168.1.50',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
   ensure => present,
 }
 ```
 
-The defined system `Unity_system['FNM00150600267']` then can be passed to any Unity resources.
+The defined system `Unity_system['FNM12345678901']` then can be passed to any Unity resources.
 
 
 * Upload a license
 
 ```puppet
 unity_license{ '/path/to/the/license.lic':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   ensure => present,
 }
 ```
@@ -117,7 +117,7 @@ Note: the path separator in the `title` must be `/` even using on Windows agent.
 
 ```puppet
 unity_pool { 'puppet_pool':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   description => 'created by puppet module',
   raid_groups => [{
     disk_group => 'dg_15',
@@ -133,7 +133,7 @@ unity_pool { 'puppet_pool':
 
 ```puppet
 unity_iscsi_portal { '10.244.213.245':
-  unity_system  => Unity_system['FNM00150600267'],
+  unity_system  => Unity_system['FNM12345678901'],
   ethernet_port => 'spa_eth3',
   netmask       => '255.255.255.0',
   vlan          => 133,
@@ -146,7 +146,7 @@ unity_iscsi_portal { '10.244.213.245':
 
 ```puppet
 unity_host { 'my_host':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   description  => 'Created by puppet',
   ip           => '192.168.1.139',
   os           => 'Ubuntu16',
@@ -163,7 +163,7 @@ unity_host { 'my_host':
 ```puppet
 # Create a Unity io limit policy (absolute limit)
 unity_io_limit_policy { 'puppet_policy':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   policy_type => 1,
   description => 'Created by puppet 12',
   max_iops => 1000,
@@ -180,7 +180,7 @@ The meaning for above burst settings is: **50% for 10 minute(s) resetting every
 
 ```puppet
 unity_lun { 'puppet_lun':
-  unity_system    => Unity_system['FNM00150600267'],
+  unity_system    => Unity_system['FNM12345678901'],
   pool            => Unity_pool['puppet_pool'],
   size            => 15,
   thin            => true,
@@ -290,7 +290,7 @@ a list of `Hash` is required for the pool.
 ```puppet
 ...
 unity_pool { 'puppet_pool':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   description  => 'created by puppet module',
   raid_groups  => [{
     disk_group   => 'dg_15',
@@ -642,17 +642,16 @@ Hosts which contain this LUN.
 
 ## Limitations
 
-TODO
 
 ## Development
 
-Simply fork the repo [puppet-unity](https://github.com/emc-openstack/puppet-unity) and send PR for your code change(also provide testing result of your change), remember to give a title and description of your PR.
+Simply fork the repo and send PR for your code change(also provide testing result of your change), remember to give a title and description of your PR.
 
 ## Contributors
 
 peter.wang13 at emc.com
 
-## Contract
+## Contact
 
 peter.wang13 at emc.com
 
diff --git a/examples/example_host.pp b/examples/example_host.pp
@@ -1,12 +1,12 @@
-unity_system { 'FNM00150600267':
-  ip       => '10.245.101.35',
+unity_system { 'FNM12345678901':
+  ip       => '192.168.1.50',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
 }
 
 #
 # unity_host { 'my_host':
-#   unity_system => Unity_system['FNM00150600267'],
+#   unity_system => Unity_system['FNM12345678901'],
 #   ip => '192.168.1.130',
 #   os_type => 'Ubuntu',
 #   host_type => 1,
@@ -15,7 +15,7 @@
 # }
 
 unity_host { 'my_host':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   description  => 'Created by puppet',
   ip           => '192.168.1.139',
   os           => 'Ubuntu16',
diff --git a/examples/example_iscsi_portal.pp b/examples/example_iscsi_portal.pp
@@ -1,12 +1,12 @@
-unity_system { 'FNM00150600267':
-  ip       => '10.245.101.35',
+unity_system { 'FNM12345678901':
+  ip       => '192.168.1.50',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
 }
 
 # Make sure the portal is created
 # unity_iscsi_portal { '10.244.213.245':
-#   unity_system  => Unity_system['FNM00150600267'],
+#   unity_system  => Unity_system['FNM12345678901'],
 #   ethernet_port => 'spa_eth3',
 #   netmask       => '255.255.255.0',
 #   vlan          => 133,
@@ -16,7 +16,7 @@
 
 # Tests that the portal is destroyed and recreated
 unity_iscsi_portal { '10.244.213.245':
-  unity_system  => Unity_system['FNM00150600267'],
+  unity_system  => Unity_system['FNM12345678901'],
   ethernet_port => 'spa_eth3',
   netmask       => '255.255.255.0',
   vlan          => 133,
diff --git a/examples/example_license.pp b/examples/example_license.pp
@@ -1,11 +1,11 @@
-unity_system { 'FNM00150600267':
-  ip       => '10.245.101.39',
+unity_system { 'FNM12345678901':
+  ip       => '192.168.1.50',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
 }
 
 
 unity_license { 'C:/Users/wangp11/RubymineProjects/puppet-unity/examples/license-any-host-Merlin-ESSENTIAL.lic':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   ensure       => present,
 }
diff --git a/examples/example_lun.pp b/examples/example_lun.pp
@@ -1,14 +1,14 @@
 
 # Define a Unity System
-unity_system { 'FNM00150600267':
-  ip       => '10.245.101.39',
+unity_system { 'FNM12345678901':
+  ip       => '192.168.1.50',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
 }
 
 # Create a Unity Pool
 unity_pool { 'puppet_pool':
-  unity_system            => Unity_system['FNM00150600267'],
+  unity_system            => Unity_system['FNM12345678901'],
   description             => 'created by puppet module',
   raid_groups             => [{
     disk_group   => 'dg_15',
@@ -24,7 +24,7 @@
 
 # Create a Unity IO limit policy (density-based)
 unity_io_limit_policy { 'puppet_policy':
-  unity_system     => Unity_system['FNM00150600267'],
+  unity_system     => Unity_system['FNM12345678901'],
   policy_type      => 2,
   description      => 'Created by puppet',
   max_iops_density => 100,
@@ -33,7 +33,7 @@
 
 # Create a Host for lun access
 unity_host { 'my_host':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   description  => 'Created by puppet',
   ip           => '192.168.1.139',
   os           => 'Ubuntu16',
@@ -46,7 +46,7 @@
 
 # Create another Host for lun access
 unity_host { 'my_host2':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   description  => 'Created by puppet2',
   ip           => '192.168.1.140',
   os           => 'Ubuntu14',
@@ -61,7 +61,7 @@
 # 1. Configure the IO limit policy
 # 2. Assign host access
 unity_lun { 'puppet_lun':
-  unity_system    => Unity_system['FNM00150600267'],
+  unity_system    => Unity_system['FNM12345678901'],
   pool            => Unity_pool['puppet_pool'],
   size            => 30,
   thin            => true,
diff --git a/examples/example_multiple_systems.pp b/examples/example_multiple_systems.pp
@@ -1,26 +1,26 @@
 # Define the first system
-unity_system { 'FNM00150600267':
-  ip       => '10.245.101.35',
+unity_system { 'FNM12345678901':
+  ip       => '192.168.1.50',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
   ensure   => present,
 }
 
 # define the second system
 unity_system { 'APM00150602415':
   ip       => '192.168.1.58',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
   ensure   => present,
 }
 
 # Create a lun in the first system
 unity_pool { 'puppet_pool':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   ensure       => present,
 }
 unity_lun { 'puppet_lun_1':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   pool         => Unity_pool['puppet_pool'],
   size         => 30,
   thin         => true,
diff --git a/examples/example_policy.pp b/examples/example_policy.pp
@@ -1,12 +1,12 @@
-unity_system { 'FNM00150600267':
-  ip       => '10.245.101.35',
+unity_system { 'FNM12345678901':
+  ip       => '192.168.1.50',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
 }
 
 # Create a Unity io limit policy (absolute limit)
 unity_io_limit_policy { 'puppet_policy':
-  unity_system => Unity_system['FNM00150600267'],
+  unity_system => Unity_system['FNM12345678901'],
   policy_type => 1,
   description => 'Created by puppet 12',
   max_iops => 1000,
diff --git a/examples/example_pool.pp b/examples/example_pool.pp
@@ -1,13 +1,13 @@
-unity_system { 'FNM00150600267':
-  ip       => '10.245.101.39',
+unity_system { 'FNM12345678901':
+  ip       => '192.168.1.50',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
 }
 
 
 
 unity_pool { 'puppet_pool':
-  unity_system            => Unity_system['FNM00150600267'],
+  unity_system            => Unity_system['FNM12345678901'],
   description             => 'created by puppet module',
   raid_groups             => [{
     disk_group   => 'dg_15',
@@ -26,7 +26,7 @@
 # uncomment the following manifest for a pool expansion
 
 # unity_pool { 'puppet_pool':
-#   unity_system            => Unity_system['FNM00150600267'],
+#   unity_system            => Unity_system['FNM12345678901'],
 #   description             => 'created by puppet module',
 #   raid_groups             => [{
 #     disk_group   => 'dg_15',
diff --git a/examples/example_system.pp b/examples/example_system.pp
@@ -1,6 +1,6 @@
-unity_system { 'FNM00150600267':
-  ip       => '10.245.101.35',
+unity_system { 'FNM12345678901':
+  ip       => '192.168.1.50',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
   ensure   => present,
 }
diff --git a/examples/example_system_wrongip.pp b/examples/example_system_wrongip.pp
@@ -1,6 +1,6 @@
-unity_system { 'FNM00150600267':
+unity_system { 'FNM12345678901':
   ip       => '10.244.101.35',
   user     => 'admin',
-  password => 'Password123!',
+  password => 'password',
   ensure   => absent,
 }
diff --git a/lib/puppet/type/unity_system.rb b/lib/puppet/type/unity_system.rb
@@ -23,7 +23,7 @@
   def self.instances
     # this code is here to support purging and the query-all functionality of the
     # 'puppet resource' command, such as:
-    # 'puppet resource unity_system  test ip=10.245.101.35 user=admin password=Password123!'
+    # 'puppet resource unity_system  test ip=192.168.1.50 user=admin password=password'
     if self.respond_to?(:ip, :user, :password)
       # figure out what to do about the separator
       Puppet.info("IP :#{ip}, USER: #{user}, PASSWORD: #{password}")

Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,11 @@`
`1`		`-unity_system { 'FNM00150600267':`
`2`		`- ip => '10.245.101.39',`
	`1`	`+unity_system { 'FNM12345678901':`
	`2`	`+ ip => '192.168.1.50',`
`3`	`3`	`user => 'admin',`
`4`		`- password => 'Password123!',`
	`4`	`+ password => 'password',`
`5`	`5`	`}`
`6`	`6`
`7`	`7`
`8`	`8`	`unity_license { 'C:/Users/wangp11/RubymineProjects/puppet-unity/examples/license-any-host-Merlin-ESSENTIAL.lic':`
`9`		`- unity_system => Unity_system['FNM00150600267'],`
	`9`	`+ unity_system => Unity_system['FNM12345678901'],`
`10`	`10`	`ensure => present,`
`11`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`		`-unity_system { 'FNM00150600267':`
	`1`	`+unity_system { 'FNM12345678901':`
`2`	`2`	`ip => '10.244.101.35',`
`3`	`3`	`user => 'admin',`
`4`		`- password => 'Password123!',`
	`4`	`+ password => 'password',`
`5`	`5`	`ensure => absent,`
`6`	`6`	`}`