Tweak code for scrutinizer issues

Author: barryvdh

src/Omnipay/Common/Helper.php

@@ -43,7 +43,7 @@ protected static function convertToLowercase($str)
     {
         $explodedStr = explode('_', $str);
         $lowercasedStr = [];
-        
+
         if (count($explodedStr) > 1) {
             foreach ($explodedStr as $value) {
                 $lowercasedStr[] = strtolower($value);

src/Omnipay/Common/Http/ResponseParser.php

@@ -32,7 +32,7 @@ private static function toString($response)
      */
     public static function json($response)
     {
-        $body = static::toString($response);
+        $body = self::toString($response);
 
         $data = json_decode($body, true);
         if (JSON_ERROR_NONE !== json_last_error()) {
@@ -60,7 +60,7 @@ public static function json($response)
      */
     public static function xml($response)
     {
-        $body = static::toString($response);
+        $body = self::toString($response);
 
         $errorMessage = null;
         $internalErrors = libxml_use_internal_errors(true);
@@ -77,9 +77,10 @@ public static function xml($response)
         libxml_use_internal_errors($internalErrors);
         libxml_disable_entity_loader($disableEntities);
 
-        if ($errorMessage) {
+        if ($errorMessage !== null) {
             throw new RuntimeException('Unable to parse response body into XML: ' . $errorMessage);
         }
+
         return $xml;
     }
 }

src/Omnipay/Common/Item.php

@@ -26,7 +26,7 @@ class Item implements ItemInterface
      *
      * @param array|null $parameters An array of parameters to set on the new object
      */
-    public function __construct($parameters = null)
+    public function __construct(array $parameters = null)
     {
         $this->initialize($parameters);
     }
@@ -37,7 +37,7 @@ public function __construct($parameters = null)
      * @param array|null $parameters An array of parameters to set on this object
      * @return $this Item
      */
-    public function initialize($parameters = null)
+    public function initialize(array $parameters = null)
     {
         $this->parameters = new ParameterBag;
 
@@ -46,6 +46,9 @@ public function initialize($parameters = null)
         return $this;
     }
 
+    /**
+     * @return array
+     */
     public function getParameters()
     {
         return $this->parameters->all();

src/Omnipay/Common/Message/AbstractResponse.php

@@ -8,6 +8,7 @@
 use Omnipay\Common\Exception\RuntimeException;
 use Symfony\Component\HttpFoundation\RedirectResponse as HttpRedirectResponse;
 use Symfony\Component\HttpFoundation\Response as HttpResponse;
+use Symfony\Component\HttpFoundation\Response;
 
 /**
  * Abstract Response
@@ -174,14 +175,15 @@ public function redirect()
     }
 
     /**
-     * @return HttpRedirectResponse
+     * @return HttpRedirectResponse|HttpResponse
      */
     public function getRedirectResponse()
     {
         if (!$this instanceof RedirectResponseInterface || !$this->isRedirect()) {
             throw new RuntimeException('This response does not support redirection.');
         }
 
+        /** @var $this RedirectResponseInterface */
         if ('GET' === $this->getRedirectMethod()) {
             return HttpRedirectResponse::create($this->getRedirectUrl());
         } elseif ('POST' === $this->getRedirectMethod()) {

src/Omnipay/Omnipay.php

@@ -72,10 +72,10 @@ class Omnipay
     public static function getFactory()
     {
         if (is_null(static::$factory)) {
-            static::$factory = new GatewayFactory;
+            self::$factory = new GatewayFactory;
         }
 
-        return static::$factory;
+        return self::$factory;
     }
 
     /**
@@ -85,7 +85,7 @@ public static function getFactory()
      */
     public static function setFactory(GatewayFactory $factory = null)
     {
-        static::$factory = $factory;
+        self::$factory = $factory;
     }
 
     /**
@@ -111,7 +111,7 @@ public static function setFactory(GatewayFactory $factory = null)
      */
     public static function __callStatic($method, $parameters)
     {
-        $factory = static::getFactory();
+        $factory = self::getFactory();
 
         return call_user_func_array(array($factory, $method), $parameters);
     }