Skip to content

Commit e525e4e

Browse files
committed
check-sof-logger: fix some quoting and rephrase some errors
Get the number of shellcheck warnings down a bit. Signed-off-by: Marc Herbert <[email protected]>
1 parent cc75f53 commit e525e4e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

test-case/check-sof-logger.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,23 +65,24 @@ func_logger_exit()
6565
}
6666

6767
# check if we get any sof-logger errors
68-
logger_err=`grep -i "error" $error_file`
68+
logger_err=$(grep -i 'error' "$error_file")
6969
if [[ $logger_err ]]; then
7070
dloge "No available log to export due to sof-logger errors."
7171
func_logger_exit 1 'error'
7272
fi
7373

7474
# '\.c\:[1-9]' to filter like '.c:6' this type keyword like:
7575
# [3017136.770833] (11.302083) c0 SA src/lib/agent.c:65 ERROR validate(), ll drift detected, delta = 25549
76-
fw_log_err=`grep -i "error" $data_file | grep -v '\.c\:[1-9]'`
76+
fw_log_err=$(grep -i 'error' "$data_file" | grep -v '\.c\:[1-9]')
77+
7778
# '[[:blank:]]TIMESTAMP.*CONTENT$' to filter the log header:
7879
# TIMESTAMP DELTA C# COMPONENT LOCATION CONTENT
79-
if [[ ! $(sed -n '/[[:blank:]]TIMESTAMP.*CONTENT$/p' $data_file) ]]; then
80-
dloge "No available log to export."
80+
if [[ ! $(sed -n '/[[:blank:]]TIMESTAMP.*CONTENT$/p' "${data_file}") ]]; then
81+
dloge "Log header not found in ${data_file}"
8182
func_logger_exit 1
8283
# we catch error from fw log
8384
elif [[ $fw_log_err ]]; then
84-
dloge "Errors in firmware log:"
85+
dloge "Error(s) found in firmware log ${data_file}"
8586
func_logger_exit 1
8687
fi
8788

0 commit comments

Comments
 (0)