Skip to content

Commit f366dc4

Browse files
committed
src: cosmetic: simplify an invalid configuration check
The condition delay_lines_size == 0 in src_params_general() can trigger if cd->param.total == 0 or if cd->param.total == -1. However, the latter is supposedly invalid and should be checked in a more generic non-negativity test, so here it suffices to just check cd->param.total != 0 before delay_lines_size is calculated. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
1 parent ac805f1 commit f366dc4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/audio/src/src_common.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -523,12 +523,12 @@ int src_params_general(struct processing_module *mod,
523523
* be aligned to 8 bytes as required by some Xtensa
524524
* instructions (e.g AE_L32X2F24_XC)
525525
*/
526-
delay_lines_size = ALIGN_UP(sizeof(int32_t) * cd->param.total, 8);
527-
if (delay_lines_size == 0) {
528-
comp_err(dev, "delay_lines_size = 0");
526+
if (cd->param.total == 0) {
527+
comp_err(dev, "configuration failed: delay_lines_size = 0");
529528

530529
return -EINVAL;
531530
}
531+
delay_lines_size = ALIGN_UP(sizeof(int32_t) * cd->param.total, 8);
532532

533533
/* free any existing delay lines. TODO reuse if same size */
534534
mod_free(mod, cd->delay_lines);

0 commit comments

Comments
 (0)