From a80d5046db82e17a186a3d1265cc4090d0aa9bde Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Wed, 27 Dec 2023 02:42:30 +0000 Subject: [PATCH 1/2] .github/sparse: upgrade to checkout@v4 and switch to filter: 'tree:0' `fetch-depth: 0` fixes git describe while `tree:0` keeps things fast. Signed-off-by: Marc Herbert --- .github/workflows/sparse-zephyr.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/sparse-zephyr.yml b/.github/workflows/sparse-zephyr.yml index 9c63e11586fd..995886bf8a74 100644 --- a/.github/workflows/sparse-zephyr.yml +++ b/.github/workflows/sparse-zephyr.yml @@ -26,22 +26,23 @@ jobs: steps: - name: git clone sparse analyzer - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: - fetch-depth: 10 # TODO: switch to thesofproject/sparse repository: marc-hb/sparse + fetch-depth: 0 + filter: 'tree:0' path: workspace/sparse - name: build sparse analyzer run: cd workspace/sparse && make -j4 - name: git clone sof - uses: actions/checkout@v3 - # From time to time this will catch a git tag and change SOF_VERSION + uses: actions/checkout@v4 with: - fetch-depth: 10 path: ./workspace/sof + fetch-depth: 0 # fix git describe + filter: 'tree:0' - name: west clones run: pip3 install west && cd workspace/sof/ && west init -l && From 5082edebadeccc011018fa6658e1a9517d802312 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Wed, 27 Dec 2023 03:01:14 +0000 Subject: [PATCH 2/2] .github/sparse: switch sparse version back to the upstream main branch This should work now that Guennadi's endianness fix 98b20341967 has been merged. Signed-off-by: Marc Herbert --- .github/workflows/sparse-zephyr.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/sparse-zephyr.yml b/.github/workflows/sparse-zephyr.yml index 995886bf8a74..aa0411882c19 100644 --- a/.github/workflows/sparse-zephyr.yml +++ b/.github/workflows/sparse-zephyr.yml @@ -28,14 +28,17 @@ jobs: - name: git clone sparse analyzer uses: actions/checkout@v4 with: - # TODO: switch to thesofproject/sparse - repository: marc-hb/sparse + repository: thesofproject/sparse fetch-depth: 0 filter: 'tree:0' path: workspace/sparse + # As of its 2023 commit 98b203419679, sparse-llvm.c uses symbols + # (LLVMConstGEP, LLVMBuildLoad, LLVMBuildCall,...) which are: + # - -Wdeprecated in LLVM v14 + # - Removed in LLVM v16 - name: build sparse analyzer - run: cd workspace/sparse && make -j4 + run: cd workspace/sparse && make -j4 # HAVE_LLVM=no - name: git clone sof uses: actions/checkout@v4