- Fix common crash when detecting low frequencies.

- Increasing margins a bit for temperament button.

Author: thetwom

app/build.gradle.kts

@@ -16,8 +16,8 @@ android {
         applicationId = "de.moekadu.tuner"
         minSdk = 23
         targetSdk = 35
-        versionCode = 40
-        versionName = "7.1.0"
+        versionCode = 41
+        versionName = "7.1.1"
         testInstrumentationRunner =  "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true
         resourceConfigurations += listOf("cs", "de", "en", "fr", "zh-rCN")

app/src/main/java/de/moekadu/tuner/MainActivity.kt

@@ -86,7 +86,8 @@ class MainActivity : ComponentActivity() {
         enableEdgeToEdge()
         super.onCreate(savedInstanceState)
 //        Log.v("Tuner", "MainActivity2.onCreate: savedInstanceState = $savedInstanceState")
-
+//        if (Build.VERSION.SDK_INT >= 27)
+//            setShowWhenLocked(true)
         runBlocking {
             migrateFromV6(this@MainActivity, pref, temperaments, instruments)
         }

app/src/main/java/de/moekadu/tuner/notedetection/TargetNoteAutoDetection.kt

@@ -18,6 +18,7 @@
 */
 package de.moekadu.tuner.notedetection
 
+import android.util.Log
 import de.moekadu.tuner.instruments.Instrument
 import de.moekadu.tuner.instruments.InstrumentIcon
 import de.moekadu.tuner.temperaments.MusicalNote
@@ -128,8 +129,9 @@ class TargetNoteAutoDetection(
                 return floatArrayOf(Float.POSITIVE_INFINITY, Float.NEGATIVE_INFINITY)
             }
             instrument.isChromatic -> {
-//                Log.v("Tuner", "TargetNoteAutoDetection: instrument.isChrmoatic")
+//                Log.v("Tuner", "TargetNoteAutoDetection: instrument.isChromatic")
                 val noteIndex = musicalScale.getNoteIndex(note)
+//                Log.v("Tuner", "TargetNoteAutoDetection.getFrequencyRangeWithinWhichWeReturnTheInputNote: note=$note, noteIndex=$noteIndex")
                 return setFrequencyRangeForChromaticTarget(noteIndex)
             }
             numDifferentNotes <= 1 -> { // always return the input note

app/src/main/java/de/moekadu/tuner/temperaments/MusicalScaleFrequencies.kt

@@ -43,10 +43,11 @@ class MusicalScaleFrequencies(
 
     /** Obtain frequency of given index.
      * @param index Note index (indexStart <= index < indexEnd)
-     * @return Frequency at given index.
+     * @return Frequency at given index. If index is out of bounds, we return the index of the
+     *    the lower/upper bound.
      */
     operator fun get(index: Int): Float {
-        return frequencies[index + indexOfReferenceNote]
+        return frequencies[(index + indexOfReferenceNote).coerceIn(0, frequencies.size-1)]
     }
 
     /** Obtain frequency by float index.

app/src/main/java/de/moekadu/tuner/ui/temperaments/TemperamentDialog.kt

@@ -136,7 +136,7 @@ fun TemperamentDialog(
                     id = R.string.temperament),
                     modifier = Modifier
                         .padding(horizontal = 16.dp)
-                        .padding(top = 8.dp),
+                        .padding(top = 16.dp),
                     style = MaterialTheme.typography.labelSmall
                 )
                 Text(
@@ -146,7 +146,12 @@ fun TemperamentDialog(
                 )
                 Text(
                     state.temperament.value.description.value(context),
-                    modifier = Modifier.padding(horizontal = 16.dp, vertical = 8.dp),
+                    modifier = Modifier.padding(
+                        start = 16.dp,
+                        end = 16.dp,
+                        top = 8.dp,
+                        bottom = 16.dp
+                    ),
                     style = MaterialTheme.typography.labelMedium
                 )
             }

fastlane/metadata/android/en-US/changelogs/41.txt

@@ -0,0 +1,12 @@
+v7.0.0:
+- New UI backend (jetpack compose).
+- (Hopefully) improved note detection for some edge cases.
+- User defined temperaments.
+
+v7.1.0:
+- Fix displaying preferences correctly on Android 15.
+- Enable edge-to-edge mode (meaning that e.g. lists are displayed
+  down to the bottom behind navigation bar).
+
+v7.1.1:
+- Fix common crash when detecting low frequencies.