Skip to content

Commit 37f7f39

Browse files
committed
Tests: don't dump when testing fishy rolenames
Don't dump rolenames when testing fishy rolenames as this leads to an error: "PermissionError: [Errno 13] Permission denied: '/.json'" Signed-off-by: Martin Vrachev <[email protected]>
1 parent 171f9ee commit 37f7f39

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tests/test_updater_with_simulator.py

+4
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,10 @@ def test_targets(self, test_case_data: Tuple[str, bytes, str]) -> None:
137137
self.assertEqual(path, updater.find_cached_target(info, path))
138138

139139
def test_fishy_rolenames(self) -> None:
140+
# Don't write in a dump folder during this test as role names could be
141+
# pointing to invalid or not permitted places.
142+
self.sim.dump_dir = None
143+
140144
roles_to_filenames = {
141145
"../a": "..%2Fa.json",
142146
".": "..json",

0 commit comments

Comments
 (0)