Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why stereo.cc is not considered to be Cuda enhanced ? #17

Open
AhmedElsafy opened this issue Sep 10, 2020 · 5 comments
Open

Why stereo.cc is not considered to be Cuda enhanced ? #17

AhmedElsafy opened this issue Sep 10, 2020 · 5 comments

Comments

@AhmedElsafy
Copy link

I see in stereo.cc it includes system.h same as mono.cc, which calls the ORBExtractor.cc which is cuda enhanced. I don't understand why it is considered not to be cuda optimized since it calls the same system object ?

@AhmedElsafy AhmedElsafy changed the title Why stereo.cc is not Cuda enhanced Why stereo.cc is not considered to be Cuda enhanced Sep 10, 2020
@AhmedElsafy AhmedElsafy changed the title Why stereo.cc is not considered to be Cuda enhanced Why stereo.cc is not considered to be Cuda enhanced ? Sep 10, 2020
@cyclojc
Copy link

cyclojc commented Nov 9, 2020

I have the same question

@thien94
Copy link
Owner

thien94 commented Nov 10, 2020

Hi @AhmedElsafy and @cyclojc , thank you for the question and sorry for the late reply.

To clarify: the CUDA enhanced components also apply to the stereo node. The "not supported" description is about testing and verifying that the nodes are indeed working as intended. Meaning, I haven't done any verification that the new stereo/RGB-D node are enhanced compared to the original ORB-SLAM2.

You can still be able to run them without any problems.

@zzjkf2009
Copy link

Based on my test result (RGBD version) running on Jetson NX, it seems like that GPUs are used, but the tracking performance is basically the same as the one without GPU enhanced. Any suggestion?

@cyclojc
Copy link

cyclojc commented Jan 18, 2021

@zzjkf2009 I had the same result, same question (using stereo version)

@thien94
Copy link
Owner

thien94 commented Jan 19, 2021

@zzjkf2009 @cyclojc for RGB-D, there are a number of newer packages that have addressed the performance and other issues that I would suggest checking out:

As for the performance of this repo, you can first replicate the same experiment with the original ORB-SLAM2 and see if there are any differences. If the problems are the same, then it would be the limitation of the underlying method. The advantage of using CUDA, at least for this repo, is to accelerate certain bottlenecks of the system. Besides that, nothing should be different performance-wise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants