Skip to content

Commit 48a62e1

Browse files
committed
Deprecate Utils.FetchThirdwebChainDataAsync
1 parent 1a6038c commit 48a62e1

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

Thirdweb.Console/Program.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150

151151
#region Chain Data Fetching
152152

153-
// var chainData = await Utils.FetchThirdwebChainDataAsync(client, 421614);
153+
// var chainData = await Utils.GetChainMetadata(client, 421614);
154154
// Console.WriteLine($"Chain data: {JsonConvert.SerializeObject(chainData, Formatting.Indented)}");
155155

156156
#endregion

Thirdweb.Tests/Thirdweb.Utils/Thirdweb.Utils.Tests.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ public async Task FetchThirdwebChainDataAsync_ReturnsChainData_WhenResponseIsSuc
440440
var timer = System.Diagnostics.Stopwatch.StartNew();
441441
var chainId = new BigInteger(1);
442442

443-
var chainData = await Utils.FetchThirdwebChainDataAsync(this._client, chainId);
443+
var chainData = await Utils.GetChainMetadata(this._client, chainId);
444444
Assert.NotNull(chainData);
445445
_ = Assert.IsType<ThirdwebChainData>(chainData);
446446

@@ -462,7 +462,7 @@ public async Task FetchThirdwebChainDataAsync_ReturnsChainData_WhenResponseIsSuc
462462
var timeAttempt1 = timer.ElapsedMilliseconds;
463463

464464
timer.Restart();
465-
var chainData2 = await Utils.FetchThirdwebChainDataAsync(this._client, chainId);
465+
var chainData2 = await Utils.GetChainMetadata(this._client, chainId);
466466
Assert.NotNull(chainData2);
467467
_ = Assert.IsType<ThirdwebChainData>(chainData);
468468

@@ -475,7 +475,7 @@ public async Task FetchThirdwebChainDataAsync_ThrowsException_WhenResponseHasErr
475475
{
476476
var chainId = 123124125418928133;
477477

478-
var exception = await Assert.ThrowsAsync<Exception>(async () => await Utils.FetchThirdwebChainDataAsync(this._client, chainId));
478+
var exception = await Assert.ThrowsAsync<Exception>(async () => await Utils.GetChainMetadata(this._client, chainId));
479479

480480
Assert.Contains("Failed to fetch chain data", exception.Message);
481481
}
@@ -485,7 +485,7 @@ public async Task FetchThirdwebChainDataAsync_ThrowsException_InvalidChainId()
485485
{
486486
var chainId = BigInteger.Zero;
487487

488-
var exception = await Assert.ThrowsAsync<ArgumentException>(async () => await Utils.FetchThirdwebChainDataAsync(this._client, chainId));
488+
var exception = await Assert.ThrowsAsync<ArgumentException>(async () => await Utils.GetChainMetadata(this._client, chainId));
489489

490490
Assert.Contains("Invalid chain", exception.Message);
491491
}

Thirdweb/Thirdweb.Utils/Utils.cs

+6
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,13 @@ public static BigInteger AdjustDecimals(this BigInteger value, int fromDecimals,
336336
return value;
337337
}
338338

339+
[Obsolete("Use Utils.GetChainMetadata instead.")]
339340
public static async Task<ThirdwebChainData> FetchThirdwebChainDataAsync(ThirdwebClient client, BigInteger chainId)
341+
{
342+
return await GetChainMetadata(client, chainId);
343+
}
344+
345+
public static async Task<ThirdwebChainData> GetChainMetadata(ThirdwebClient client, BigInteger chainId)
340346
{
341347
if (_chainDataCache.TryGetValue(chainId, out var value))
342348
{

0 commit comments

Comments
 (0)