redundant catch, better errors thrown

Author: 0xFirekeeper

Thirdweb/Thirdweb.Contracts/ThirdwebContract.cs

@@ -106,16 +106,13 @@ public static async Task<T> Read<T>(ThirdwebContract contract, string method, pa
             {
                 if (method.Contains("("))
                 {
-                    try
-                    {
-                        var canonicalSignature = ExtractCanonicalSignature(method);
-                        var selector = Nethereum.Util.Sha3Keccack.Current.CalculateHash(canonicalSignature)[..8];
-                        function = contractRaw.GetFunctionBySignature(selector);
-                    }
-                    catch
-                    {
-                        function = contractRaw.GetFunction(method);
-                    }
+                    var canonicalSignature = ExtractCanonicalSignature(method);
+                    var selector = Nethereum.Util.Sha3Keccack.Current.CalculateHash(canonicalSignature)[..8];
+                    function = contractRaw.GetFunctionBySignature(selector);
+                }
+                else
+                {
+                    throw new ArgumentException("Method signature not found in contract ABI.");
                 }
             }
 
@@ -142,16 +139,13 @@ public static async Task<ThirdwebTransaction> Prepare(IThirdwebWallet wallet, Th
             {
                 if (method.Contains("("))
                 {
-                    try
-                    {
-                        var canonicalSignature = ExtractCanonicalSignature(method);
-                        var selector = Nethereum.Util.Sha3Keccack.Current.CalculateHash(canonicalSignature)[..8];
-                        function = contractRaw.GetFunctionBySignature(selector);
-                    }
-                    catch
-                    {
-                        function = contractRaw.GetFunction(method);
-                    }
+                    var canonicalSignature = ExtractCanonicalSignature(method);
+                    var selector = Nethereum.Util.Sha3Keccack.Current.CalculateHash(canonicalSignature)[..8];
+                    function = contractRaw.GetFunctionBySignature(selector);
+                }
+                else
+                {
+                    throw new ArgumentException("Method signature not found in contract ABI.");
                 }
             }