- chore: Remove env variable while 'SKIP_PROPS_VALIDATION' while test

- feat: Add throw expectation while setting cpu/memory in ComputeCapacity

Author: MohamedElmdary

.github/workflows/grid_client_tests.yml

@@ -23,7 +23,6 @@ jobs:
       RMB_PROXY: true
       STORE_SECRET: secret
       MNEMONIC: ${{ secrets.MNEMONIC }}
-      SKIP_PROPS_VALIDATION: true
     steps:
       - name: set network for Schedule
         if: ${{env.NETWORK}} == ""

packages/grid_client/tests/modules/compute_capacity.test.ts

@@ -15,35 +15,38 @@ describe("Compute Capacity module", () => {
     const cpu = 0;
     const mem = 255 * 1024 ** 2;
 
-    computeCapacity.cpu = cpu;
-    computeCapacity.memory = mem;
-
+    const setCPU = () => (computeCapacity.cpu = cpu);
+    const setMem = () => (computeCapacity.memory = mem);
     const result = () => computeCapacity.challenge();
 
+    expect(setCPU).toThrow();
+    expect(setMem).toThrow();
     expect(result).toThrow();
   });
 
   test("Max values for cpu & memory.", () => {
     const cpu = 33;
     const mem = 255 * 1024 ** 4;
 
-    computeCapacity.cpu = cpu;
-    computeCapacity.memory = mem;
-
+    const setCPU = () => (computeCapacity.cpu = cpu);
+    const setMem = () => (computeCapacity.memory = mem);
     const result = () => computeCapacity.challenge();
 
+    expect(setCPU).toThrow();
+    expect(setMem).toThrow();
     expect(result).toThrow();
   });
 
   test("cpu & memory doesn't accept decimal values.", () => {
     const cpu = 1.5;
     const mem = 1.2;
 
-    computeCapacity.cpu = cpu;
-    computeCapacity.memory = mem;
-
+    const setCPU = () => (computeCapacity.cpu = cpu);
+    const setMem = () => (computeCapacity.memory = mem);
     const result = () => computeCapacity.challenge();
 
+    expect(setCPU).toThrow();
+    expect(setMem).toThrow();
     expect(result).toThrow();
   });
 
@@ -57,11 +60,12 @@ describe("Compute Capacity module", () => {
     const negative_cpu = -1;
     const negative_mem = -1;
 
-    computeCapacity.cpu = negative_cpu;
-    computeCapacity.memory = negative_mem;
-
+    const setCPU = () => (computeCapacity.cpu = negative_cpu);
+    const setMem = () => (computeCapacity.memory = negative_mem);
     const result = () => computeCapacity.challenge();
 
+    expect(setCPU).toThrow();
+    expect(setMem).toThrow();
     expect(result).toThrow();
   });
 });