Merge pull request #18 from threefoldtech/add-validation-to-workload-name-length

Eslam-Nawara · web-flow · commit 5d06ff71639c · 2024-10-21T10:19:37.000+03:00
add validation to workload name length
diff --git a/pkg/gridtypes/id.go b/pkg/gridtypes/id.go
@@ -80,6 +80,11 @@ func IsValidName(n Name) error {
 		return fmt.Errorf("name cannot be empty")
 	}
 
+	// this because max virtio fs tag length is 36 and it is used by cloud-hypervisor
+	if len(n) > 36 {
+		return fmt.Errorf("name cannot exceed 36 characters")
+	}
+
 	if !nameMatch.MatchString(string(n)) {
 		return fmt.Errorf("unsupported character in workload name")
 	}

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,11 @@ func IsValidName(n Name) error {`
`80`	`80`	`return fmt.Errorf("name cannot be empty")`
`81`	`81`	`}`
`82`	`82`
	`83`	`+ // this because max virtio fs tag length is 36 and it is used by cloud-hypervisor`
	`84`	`+ if len(n) > 36 {`
	`85`	`+ return fmt.Errorf("name cannot exceed 36 characters")`
	`86`	`+ }`
	`87`	`+`
`83`	`88`	`if !nameMatch.MatchString(string(n)) {`
`84`	`89`	`return fmt.Errorf("unsupported character in workload name")`
`85`	`90`	`}`