Skip to content

Commit c050d79

Browse files
committed
Address review comments
1 parent 729228e commit c050d79

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

xml_struct_derive/src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ use crate::serialize::{write_serialize_impl_for_enum, write_serialize_impl_for_s
1313

1414
const MACRO_ATTRIBUTE: &str = "xml_struct";
1515

16-
#[proc_macro_derive(XmlSerialize, attributes(xml_struct))]
1716
/// A macro providing automated derivation of the `XmlSerialize` and
1817
/// `XmlSerializeAttr` traits.
1918
///
@@ -163,6 +162,7 @@ const MACRO_ATTRIBUTE: &str = "xml_struct";
163162
/// ```text
164163
/// <foo:Field/>
165164
/// ```
165+
#[proc_macro_derive(XmlSerialize, attributes(xml_struct))]
166166
pub fn derive_xml_serialize(input: proc_macro::TokenStream) -> proc_macro::TokenStream {
167167
let input = parse_macro_input!(input as DeriveInput);
168168

xml_struct_derive/src/properties.rs

+3-4
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
use proc_macro2::TokenStream;
66
use quote::ToTokens as _;
77
use syn::{
8-
punctuated::Punctuated, spanned::Spanned as _, token::Comma, Attribute, DeriveInput, Error,
9-
Expr, Meta,
8+
punctuated::Punctuated, spanned::Spanned as _, Attribute, DeriveInput, Error, Expr, Meta, Token,
109
};
1110

1211
use crate::MACRO_ATTRIBUTE;
@@ -70,7 +69,7 @@ impl TypeProps {
7069
let mut errors = Vec::default();
7170

7271
let mut properties = TypeProps::default();
73-
for meta in attr.parse_args_with(Punctuated::<Meta, Comma>::parse_terminated)? {
72+
for meta in attr.parse_args_with(Punctuated::<Meta, Token![,]>::parse_terminated)? {
7473
match meta {
7574
Meta::Path(path) => {
7675
if path.is_ident("text") {
@@ -252,7 +251,7 @@ impl FieldProps {
252251
let mut errors = Vec::default();
253252

254253
let mut properties = FieldProps::default();
255-
for meta in attr.parse_args_with(Punctuated::<Meta, Comma>::parse_terminated)? {
254+
for meta in attr.parse_args_with(Punctuated::<Meta, Token![,]>::parse_terminated)? {
256255
match meta {
257256
Meta::Path(path) => {
258257
if path.is_ident("attribute") {

0 commit comments

Comments
 (0)