Skip to content

Commit 9e65c9b

Browse files
authored
Merge branch 'master' into androidWebViewScrolling
2 parents 4c7e8f8 + a7b145d commit 9e65c9b

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

android/cli/hooks/run.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,10 @@ exports.init = function (logger, config, cli) {
254254

255255
// start of a new log message
256256
if (device.appPidRegExp.test(line)) {
257-
line = line.trim().replace(device.appPidRegExp, ':');
257+
line = line.replace(/^ {1,2}/, '').replace(device.appPidRegExp, ':');
258258
logLevel = line.charAt(0).toLowerCase();
259259
if (tiapiRegExp.test(line)) {
260-
line = line.replace(tiapiRegExp, '').trim();
260+
line = line.replace(tiapiRegExp, '').replace(/^ {1,2}/, '');
261261
} else {
262262
line = line.replace(/^\w\/(\w+)\s*:/g, '$1:').grey;
263263
}

android/modules/ui/src/java/ti/modules/titanium/ui/TabGroupProxy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@ public void onTabSelected(TabProxy tabProxy)
569569
tabProxy.onSelectionChanged(true);
570570
tabProxy.onFocusChanged(true, focusEventData);
571571

572-
tabProxy.fireEvent(TiC.EVENT_SELECTED, null, false);
572+
tabProxy.fireEvent(TiC.EVENT_SELECTED, focusEventData, false);
573573
}
574574

575575
@Override

android/modules/ui/src/java/ti/modules/titanium/ui/widget/tabgroup/TiUIBottomNavigationTabGroup.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,11 +344,17 @@ public void updateTabBackgroundDrawable(int index)
344344
try {
345345
// BottomNavigationMenuView rebuilds itself after adding a new item, so we need to reset the colors each time.
346346
TiViewProxy tabProxy = tabs.get(index).getProxy();
347-
if (hasCustomBackground(tabProxy) || hasCustomIconTint(tabProxy)) {
347+
boolean hasTouchFeedbackColor = tabProxy.hasPropertyAndNotNull(TiC.PROPERTY_TOUCH_FEEDBACK_COLOR);
348+
if (hasCustomBackground(tabProxy) || hasCustomIconTint(tabProxy) || hasTouchFeedbackColor) {
348349
BottomNavigationMenuView bottomMenuView =
349350
((BottomNavigationMenuView) this.mBottomNavigationView.getChildAt(0));
350351
Drawable drawable = createBackgroundDrawableForState(tabProxy, android.R.attr.state_checked);
351-
drawable = new RippleDrawable(createRippleColorStateListFrom(getActiveColor(tabProxy)), drawable, null);
352+
int color = getActiveColor(tabProxy);
353+
if (hasTouchFeedbackColor) {
354+
color = TiConvert.toColor(tabProxy.getProperty(TiC.PROPERTY_TOUCH_FEEDBACK_COLOR),
355+
tabProxy.getActivity());
356+
}
357+
drawable = new RippleDrawable(createRippleColorStateListFrom(color), drawable, null);
352358
bottomMenuView.getChildAt(index).setBackground(drawable);
353359
}
354360
} catch (Exception e) {

0 commit comments

Comments
 (0)