no more expect_error()

EmilHvitfeldt · EmilHvitfeldt · commit 2ee21c22bca5 · 2024-09-24T14:15:14.000-07:00
diff --git a/tests/testthat/test-dummy_hash.R b/tests/testthat/test-dummy_hash.R
@@ -231,9 +231,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = test_data),
-    NA
+  expect_no_error(
+    bake(rec, new_data = test_data)
   )
 })
 
diff --git a/tests/testthat/test-lda.R b/tests/testthat/test-lda.R
@@ -175,9 +175,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = tate_text[seq_len(n_rows), ]),
-    NA
+  expect_no_error(
+    bake(rec, new_data = tate_text[seq_len(n_rows), ])
   )
 })
 
diff --git a/tests/testthat/test-sequence_onehot.R b/tests/testthat/test-sequence_onehot.R
@@ -237,9 +237,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = test_data),
-    NA
+  expect_no_error(
+    bake(rec, new_data = test_data)
   )
 })
 
diff --git a/tests/testthat/test-textfeature.R b/tests/testthat/test-textfeature.R
@@ -178,9 +178,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = test_data),
-    NA
+  expect_no_error(
+    bake(rec, new_data = test_data)
   )
 })
 test_that("keep_original_cols works", {
@@ -219,9 +218,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = test_data),
-    NA
+  expect_no_error(
+    bake(rec, new_data = test_data)
   )
 })
 
diff --git a/tests/testthat/test-texthash.R b/tests/testthat/test-texthash.R
@@ -215,9 +215,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = test_data),
-    NA
+  expect_no_error(
+    bake(rec, new_data = test_data)
   )
 })
 
diff --git a/tests/testthat/test-tf.R b/tests/testthat/test-tf.R
@@ -246,9 +246,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = test_data),
-    NA
+  expect_no_error(
+    bake(rec, new_data = test_data)
   )
 })
 
diff --git a/tests/testthat/test-tfidf.R b/tests/testthat/test-tfidf.R
@@ -235,9 +235,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = test_data),
-    NA
+  expect_no_error(
+    bake(rec, new_data = test_data)
   )
 })
 
diff --git a/tests/testthat/test-tokenmerge.R b/tests/testthat/test-tokenmerge.R
@@ -165,9 +165,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = test_data),
-    NA
+  expect_no_error(
+    bake(rec, new_data = test_data)
   )
 })
 
diff --git a/tests/testthat/test-word_embeddings.R b/tests/testthat/test-word_embeddings.R
@@ -137,9 +137,8 @@ test_that("step_word_embeddings deals with missing words appropriately.", {
   new_text <- tibble(
     text = "aksjdf nagjli aslkfa"
   )
-  expect_error(
-    bake(obj, new_data = new_text),
-    NA
+  expect_no_error(
+    bake(obj, new_data = new_text)
   )
 })
 
@@ -377,9 +376,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {
     rec <- prep(rec)
   )
   
-  expect_error(
-    bake(rec, new_data = test_data),
-    NA
+  expect_no_error(
+    bake(rec, new_data = test_data)
   )
 })
 

Original file line number	Diff line number	Diff line change
`@@ -231,9 +231,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`231`	`231`	`rec <- prep(rec)`
`232`	`232`	`)`
`233`	`233`
`234`		`- expect_error(`
`235`		`- bake(rec, new_data = test_data),`
`236`		`- NA`
	`234`	`+ expect_no_error(`
	`235`	`+ bake(rec, new_data = test_data)`
`237`	`236`	`)`
`238`	`237`	`})`
`239`	`238`
Original file line number	Diff line number	Diff line change
`@@ -175,9 +175,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`175`	`175`	`rec <- prep(rec)`
`176`	`176`	`)`
`177`	`177`
`178`		`- expect_error(`
`179`		`- bake(rec, new_data = tate_text[seq_len(n_rows), ]),`
`180`		`- NA`
	`178`	`+ expect_no_error(`
	`179`	`+ bake(rec, new_data = tate_text[seq_len(n_rows), ])`
`181`	`180`	`)`
`182`	`181`	`})`
`183`	`182`
Original file line number	Diff line number	Diff line change
`@@ -237,9 +237,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`237`	`237`	`rec <- prep(rec)`
`238`	`238`	`)`
`239`	`239`
`240`		`- expect_error(`
`241`		`- bake(rec, new_data = test_data),`
`242`		`- NA`
	`240`	`+ expect_no_error(`
	`241`	`+ bake(rec, new_data = test_data)`
`243`	`242`	`)`
`244`	`243`	`})`
`245`	`244`
Original file line number	Diff line number	Diff line change
`@@ -178,9 +178,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`178`	`178`	`rec <- prep(rec)`
`179`	`179`	`)`
`180`	`180`
`181`		`- expect_error(`
`182`		`- bake(rec, new_data = test_data),`
`183`		`- NA`
	`181`	`+ expect_no_error(`
	`182`	`+ bake(rec, new_data = test_data)`
`184`	`183`	`)`
`185`	`184`	`})`
`186`	`185`	`test_that("keep_original_cols works", {`
`@@ -219,9 +218,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`219`	`218`	`rec <- prep(rec)`
`220`	`219`	`)`
`221`	`220`
`222`		`- expect_error(`
`223`		`- bake(rec, new_data = test_data),`
`224`		`- NA`
	`221`	`+ expect_no_error(`
	`222`	`+ bake(rec, new_data = test_data)`
`225`	`223`	`)`
`226`	`224`	`})`
`227`	`225`
Original file line number	Diff line number	Diff line change
`@@ -215,9 +215,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`215`	`215`	`rec <- prep(rec)`
`216`	`216`	`)`
`217`	`217`
`218`		`- expect_error(`
`219`		`- bake(rec, new_data = test_data),`
`220`		`- NA`
	`218`	`+ expect_no_error(`
	`219`	`+ bake(rec, new_data = test_data)`
`221`	`220`	`)`
`222`	`221`	`})`
`223`	`222`
Original file line number	Diff line number	Diff line change
`@@ -246,9 +246,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`246`	`246`	`rec <- prep(rec)`
`247`	`247`	`)`
`248`	`248`
`249`		`- expect_error(`
`250`		`- bake(rec, new_data = test_data),`
`251`		`- NA`
	`249`	`+ expect_no_error(`
	`250`	`+ bake(rec, new_data = test_data)`
`252`	`251`	`)`
`253`	`252`	`})`
`254`	`253`
Original file line number	Diff line number	Diff line change
`@@ -235,9 +235,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`235`	`235`	`rec <- prep(rec)`
`236`	`236`	`)`
`237`	`237`
`238`		`- expect_error(`
`239`		`- bake(rec, new_data = test_data),`
`240`		`- NA`
	`238`	`+ expect_no_error(`
	`239`	`+ bake(rec, new_data = test_data)`
`241`	`240`	`)`
`242`	`241`	`})`
`243`	`242`
Original file line number	Diff line number	Diff line change
`@@ -165,9 +165,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`165`	`165`	`rec <- prep(rec)`
`166`	`166`	`)`
`167`	`167`
`168`		`- expect_error(`
`169`		`- bake(rec, new_data = test_data),`
`170`		`- NA`
	`168`	`+ expect_no_error(`
	`169`	`+ bake(rec, new_data = test_data)`
`171`	`170`	`)`
`172`	`171`	`})`
`173`	`172`
Original file line number	Diff line number	Diff line change
`@@ -137,9 +137,8 @@ test_that("step_word_embeddings deals with missing words appropriately.", {`
`137`	`137`	`new_text <- tibble(`
`138`	`138`	`text = "aksjdf nagjli aslkfa"`
`139`	`139`	`)`
`140`		`- expect_error(`
`141`		`- bake(obj, new_data = new_text),`
`142`		`- NA`
	`140`	`+ expect_no_error(`
	`141`	`+ bake(obj, new_data = new_text)`
`143`	`142`	`)`
`144`	`143`	`})`
`145`	`144`
`@@ -377,9 +376,8 @@ test_that("keep_original_cols - can prep recipes with it missing", {`
`377`	`376`	`rec <- prep(rec)`
`378`	`377`	`)`
`379`	`378`
`380`		`- expect_error(`
`381`		`- bake(rec, new_data = test_data),`
`382`		`- NA`
	`379`	`+ expect_no_error(`
	`380`	`+ bake(rec, new_data = test_data)`
`383`	`381`	`)`
`384`	`382`	`})`
`385`	`383`