Skip to content

The grammarlessness of borders() #6392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teunbrand opened this issue Apr 2, 2025 · 0 comments · May be fixed by #6399
Open

The grammarlessness of borders() #6392

teunbrand opened this issue Apr 2, 2025 · 0 comments · May be fixed by #6399

Comments

@teunbrand
Copy link
Collaborator

teunbrand commented Apr 2, 2025

There is a layer constructor function called borders(). It draws geographical borders. While it is not a bad name for a function on itself, it doesn't really "fit" in the established grammar of ggplot2. For example, it is not immediately clear that borders() is dissimilar to a helper like margins() or is unrelated to gt::cell_borders(). It isn't on face-value related to any of the other grammar components, so it is not intuitive that it can be +-ed to a plot.

I think it should become something like annotation_borders(), where it is at least clear that it falls with the 'annotation'-flavour of layers.

@teunbrand teunbrand linked a pull request Apr 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant