You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Geom$optional_aes and Stat$optional_aes fields seem redundant to me.
Instead of having these fields, we can declare default_aes = aes(optional_aesthetic = NULL).
While I would like to see these fields go in their entirety, that seems like backward incompatible, so instead I propose to discourage these fields. We can (i) remove any references to that field in the extension vignette (ii) ensure we adopt the NULL-aesthetic approach within ggplot2 and (iii) check if the ggplot book would need to be adapted.
If we're in a violent mood we can start throwing deprecation warnings about that field, but it seems sensible to discourage first and reconsider the next release cycle.
The text was updated successfully, but these errors were encountered:
The
Geom$optional_aes
andStat$optional_aes
fields seem redundant to me.Instead of having these fields, we can declare
default_aes = aes(optional_aesthetic = NULL)
.While I would like to see these fields go in their entirety, that seems like backward incompatible, so instead I propose to discourage these fields. We can (i) remove any references to that field in the extension vignette (ii) ensure we adopt the NULL-aesthetic approach within ggplot2 and (iii) check if the ggplot book would need to be adapted.
If we're in a violent mood we can start throwing deprecation warnings about that field, but it seems sensible to discourage first and reconsider the next release cycle.
The text was updated successfully, but these errors were encountered: