Skip to content

Discourage use of optional_aes field #6393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teunbrand opened this issue Apr 2, 2025 · 0 comments · May be fixed by #6400
Open

Discourage use of optional_aes field #6393

teunbrand opened this issue Apr 2, 2025 · 0 comments · May be fixed by #6400

Comments

@teunbrand
Copy link
Collaborator

teunbrand commented Apr 2, 2025

The Geom$optional_aes and Stat$optional_aes fields seem redundant to me.
Instead of having these fields, we can declare default_aes = aes(optional_aesthetic = NULL).
While I would like to see these fields go in their entirety, that seems like backward incompatible, so instead I propose to discourage these fields. We can (i) remove any references to that field in the extension vignette (ii) ensure we adopt the NULL-aesthetic approach within ggplot2 and (iii) check if the ggplot book would need to be adapted.
If we're in a violent mood we can start throwing deprecation warnings about that field, but it seems sensible to discourage first and reconsider the next release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant