Skip to content

Feature request: expose outer.radius in coord_radial() #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yunuuuu opened this issue Mar 26, 2025 · 3 comments · May be fixed by #6401
Open

Feature request: expose outer.radius in coord_radial() #6379

Yunuuuu opened this issue Mar 26, 2025 · 3 comments · May be fixed by #6401

Comments

@Yunuuuu
Copy link
Contributor

Yunuuuu commented Mar 26, 2025

coord_radial() currently has outer.radius hardcoded to 0.8 (0.4 = 0.8/2), preventing users from adjusting the large spacing described in: #6284.

If this looks good, I can submit a pull request.

@teunbrand
Copy link
Collaborator

teunbrand commented Mar 26, 2025

I think this'll complicate axis placement, but if this can be done without negatively affecting these at various radii, I'm not against this. However, I think this would be best parameterised as a margin/padding/spacing, rather than giving direct control over the radii.

@Yunuuuu
Copy link
Contributor Author

Yunuuuu commented Mar 30, 2025

That makes sense. If we parameterize this as a margin/padding/spacing, would it conflict with the plot margin defined in the theme? Or would it be appropriate to make this parameter an element within the theme itself?

@teunbrand
Copy link
Collaborator

I don't think the theme is available when data is being transformed, so I don't think a theme setting would make a lot of sense from a plumbing perspective. There'd be a slight semantic overlap between the spacing and the plot.margin, but I'm not too worried about this.

@Yunuuuu Yunuuuu linked a pull request Apr 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants