REVERT ME: Break for data frames for compatibility with codebook

krlmlr · krlmlr · commit 885c19148054 · 2021-07-23T04:22:37.000+02:00
rubenarslan/codebook#68, CC @rubenarslan
diff --git a/R/enframe.R b/R/enframe.R
@@ -28,7 +28,8 @@ enframe <- function(x, name = "name", value = "value") {
     x <- logical()
   }
 
-  if (!vec_is(x)) {
+  # FIXME: Enable again for data frames, add test
+  if (!vec_is(x) || is.data.frame(x)) {
     cnd_signal(error_enframe_must_be_vector(x))
   }
 

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@ enframe <- function(x, name = "name", value = "value") {`
`28`	`28`	`x <- logical()`
`29`	`29`	`}`
`30`	`30`
`31`		`- if (!vec_is(x)) {`
	`31`	`+ # FIXME: Enable again for data frames, add test`
	`32`	`+ if (!vec_is(x) \|\| is.data.frame(x)) {`
`32`	`33`	`cnd_signal(error_enframe_must_be_vector(x))`
`33`	`34`	`}`
`34`	`35`