Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database plugin #28

Closed
poirierlouis opened this issue Nov 26, 2024 · 4 comments
Closed

Add database plugin #28

poirierlouis opened this issue Nov 26, 2024 · 4 comments
Labels
enhancement New feature or request server wontfix This will not be worked on

Comments

@poirierlouis
Copy link
Collaborator

This is to continue on conversation #21 (comment)

Could it be created as a facade, such as only one plugin API (Database) is used by other plugins. But actual implementation of the database would be separate plugins like PostgresDatabase, MongoDatabase?
Maybe it would require two facades, one for NoSQL and another for SQL.

wdyt?

@poirierlouis poirierlouis added enhancement New feature or request server labels Nov 26, 2024
@maximegmd
Copy link
Member

I don't think we need a database plugin. Plugins that need a DB can easily interface with whatever database they want by just importing existing libs.

@maximegmd
Copy link
Member

@poirierlouis
Copy link
Collaborator Author

Hum I see, this Entity Framework Core is nice. So basically, server owners would handle storage of stats/inventory/etc. themself instead of providing a common ground through a plugin?

@maximegmd
Copy link
Member

Yes, persistence isn't the goal of the base framework, this can be handled by plugins.

@poirierlouis poirierlouis added the wontfix This will not be worked on label Nov 27, 2024
@poirierlouis poirierlouis closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants