Skip to content

Commit c267a6d

Browse files
authored
feat!: removes Node.js 18 as it reached EOL (#742)
1 parent aff797a commit c267a6d

File tree

12 files changed

+5
-177
lines changed

12 files changed

+5
-177
lines changed

.github/workflows/buildx.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
fail-fast: false
1616
matrix:
1717
ruby-version: [3.2, 3.3, 3.4]
18-
node-version: [18, 20, 22]
18+
node-version: [20, 22]
1919
variant: [default, slim, alpine]
2020
include:
2121
- variant: default
@@ -32,7 +32,6 @@ jobs:
3232
id: nodename
3333
run: |
3434
case "${{ matrix.node-version }}" in
35-
"18") echo "codename=hydrogen" >> $GITHUB_OUTPUT ;;
3635
"20") echo "codename=iron" >> $GITHUB_OUTPUT ;;
3736
"22") echo "codename=jod" >> $GITHUB_OUTPUT ;;
3837
"24") echo "codename=krypton" >> $GITHUB_OUTPUT ;;

.github/workflows/dockerimage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
fail-fast: false
1515
matrix:
1616
ruby-version: [3.2, 3.3, 3.4]
17-
node-version: [18, 20, 22]
17+
node-version: [20, 22]
1818
variant: [default, slim, alpine]
1919

2020
steps:

3.2/18/Dockerfile

Lines changed: 0 additions & 19 deletions
This file was deleted.

3.2/18/alpine/Dockerfile

Lines changed: 0 additions & 13 deletions
This file was deleted.

3.2/18/slim/Dockerfile

Lines changed: 0 additions & 25 deletions
This file was deleted.

3.3/18/Dockerfile

Lines changed: 0 additions & 19 deletions
This file was deleted.

3.3/18/alpine/Dockerfile

Lines changed: 0 additions & 13 deletions
This file was deleted.

3.3/18/slim/Dockerfile

Lines changed: 0 additions & 25 deletions
This file was deleted.

3.4/18/Dockerfile

Lines changed: 0 additions & 19 deletions
This file was deleted.

3.4/18/alpine/Dockerfile

Lines changed: 0 additions & 13 deletions
This file was deleted.

3.4/18/slim/Dockerfile

Lines changed: 0 additions & 25 deletions
This file was deleted.

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
# Ruby 3.2, 3.3 or 3.4 with Node.js 18 LTS, Node.js 20 LTS or Node.js 22 Dockerfile
1+
# Ruby 3.2, 3.3 or 3.4 with Node.js 20 LTS or Node.js 22 Dockerfile
22

33
[![Docker Automated build](https://img.shields.io/docker/automated/timbru31/ruby-node.svg)](https://hub.docker.com/r/timbru31/ruby-node/)
44
[![buildx Status](https://github.com/timbru31/docker-ruby-node/workflows/buildx/badge.svg)](https://github.com/timbru31/docker-ruby-node/actions?query=workflow%3Abuildx)
55
[![Lint Dockerfiles](https://github.com/timbru31/docker-ruby-node/workflows/Lint%20Dockerfiles/badge.svg)](https://github.com/timbru31/docker-ruby-node/actions?query=workflow%3A%22Lint+Dockerfiles%22)
66

7-
A minimal Dockerfile based on Ruby (3.2, 3.3 or 3.4) Dockerfile (regular, slim or alpine) with Node.js 18 LTS (Hydrogen), Node.js 20 LTS (Iron) or Node.js 22 LTS (Jod) installed.
7+
A minimal Dockerfile based on Ruby (3.2, 3.3 or 3.4) Dockerfile (regular, slim or alpine) with Node.js 20 LTS (Iron) or Node.js 22 LTS (Jod) installed.
88

99
## What's included
1010

1111
- Ruby 3.2, 3.3, 3.4
12-
- Node.js 18 LTS (Hydrogen), Node.js 20 LTS (Iron) or Node.js 22 LTS (Jod)
12+
- Node.js 20 LTS (Iron) or Node.js 22 LTS (Jod)
1313
- bundled npm that comes with the respective Node.js version (latest for Node.js LTS on alpine, see [why](https://gitlab.alpinelinux.org/alpine/aports/-/commit/25b10bd1a93e12a7e49fee38b0a229281ae49fb7))
1414
- yarn
1515

0 commit comments

Comments
 (0)