Skip to content

Commit ac919e5

Browse files
authored
Fix schema dump of continuous aggregate when no refresh policies are defined (#68)
1 parent 88c5cfa commit ac919e5

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/timescaledb/schema_dumper.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,14 +159,14 @@ def timescale_continuous_aggregates(stream)
159159
interval = timescale_interval(refresh_policy.schedule_interval)
160160
end_offset = timescale_interval(refresh_policy.config["end_offset"])
161161
start_offset = timescale_interval(refresh_policy.config["start_offset"])
162-
%(refresh_policies: { start_offset: "#{start_offset}", end_offset: "#{end_offset}", schedule_interval: "#{interval}"})
162+
%(refresh_policies: { start_offset: "#{start_offset}", end_offset: "#{end_offset}", schedule_interval: "#{interval}"}, )
163163
else
164164
""
165165
end
166166

167167
with_clause_opts = "materialized_only: #{aggregate[:materialized_only]}, finalized: #{aggregate[:finalized]}"
168168
stream.puts <<~AGG.indent(2)
169-
create_continuous_aggregate("#{aggregate.view_name}", <<-SQL, #{refresh_policies_opts}, #{with_clause_opts})
169+
create_continuous_aggregate("#{aggregate.view_name}", <<-SQL, #{refresh_policies_opts}#{with_clause_opts})
170170
#{aggregate.view_definition.strip.gsub(/;$/, '')}
171171
SQL
172172
AGG

spec/timescaledb/schema_dumper_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
expect(dump).to include 'create_continuous_aggregate("event_counts"'
8686
expect(dump).to include 'materialized_only: true, finalized: true'
8787

88+
expect(dump).not_to include ', ,'
8889
expect(dump).not_to include 'create_view "event_counts"' # Verify Scenic ignored this view
8990
expect(dump).to include 'create_view "searches", sql_definition: <<-SQL' if defined?(Scenic)
9091

0 commit comments

Comments
 (0)