Skip to content

Commit d14ba4a

Browse files
authored
Update configuration on latest 3.x template (jupyterlab#1248)
* Update configuration on latest 3.x template * Fix CI * More CI fixes * More CI fixes * Fix jest configuration * Fix Jest tests * TOML does not support interpolation * Fix installation path * Lint the code * Fix test set up * Remove `prepare` script to fix check releaser * Add releaser pointing to personal version * Only generate the version file as `prepare` step
1 parent a402291 commit d14ba4a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+2586
-1504
lines changed

.eslintrc.js

+47-48
Original file line numberDiff line numberDiff line change
@@ -1,52 +1,51 @@
11
module.exports = {
2-
extends: [
3-
'eslint:recommended',
4-
'plugin:@typescript-eslint/eslint-recommended',
5-
'plugin:@typescript-eslint/recommended',
6-
'plugin:prettier/recommended',
7-
'plugin:react/recommended'
8-
],
9-
parser: '@typescript-eslint/parser',
10-
parserOptions: {
11-
project: 'tsconfig.json',
12-
sourceType: 'module'
13-
},
14-
plugins: ['@typescript-eslint'],
15-
rules: {
16-
'@typescript-eslint/explicit-function-return-type': 'off',
17-
"@typescript-eslint/naming-convention": [
18-
"error",
19-
{
20-
"selector": "interface",
21-
"format": ["PascalCase"],
22-
"custom": {
23-
"regex": "^I[A-Z]",
24-
"match": true
25-
}
2+
extends: [
3+
'eslint:recommended',
4+
'plugin:@typescript-eslint/eslint-recommended',
5+
'plugin:@typescript-eslint/recommended',
6+
'plugin:react/recommended'
7+
],
8+
parser: '@typescript-eslint/parser',
9+
parserOptions: {
10+
project: 'tsconfig.test.json',
11+
sourceType: 'module'
12+
},
13+
plugins: ['@typescript-eslint'],
14+
rules: {
15+
'@typescript-eslint/explicit-function-return-type': 'off',
16+
'@typescript-eslint/naming-convention': [
17+
'error',
18+
{
19+
selector: 'interface',
20+
format: ['PascalCase'],
21+
custom: {
22+
regex: '^I[A-Z]',
23+
match: true
2624
}
27-
],
28-
'@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
29-
'@typescript-eslint/no-explicit-any': 'off',
30-
'@typescript-eslint/no-namespace': 'off',
31-
'@typescript-eslint/no-this-alias': [
32-
'error',
33-
{
34-
allowedNames: ['self'], // Allow `const self = this`
35-
},
36-
],
37-
'@typescript-eslint/no-use-before-define': 'off',
38-
'@typescript-eslint/quotes': [
39-
'error',
40-
'single',
41-
{ avoidEscape: true, allowTemplateLiterals: false }
42-
],
43-
curly: ['error', 'all'],
44-
eqeqeq: 'error',
45-
'prefer-arrow-callback': 'error'
46-
},
47-
settings: {
48-
react: {
49-
version: 'detect'
5025
}
26+
],
27+
'@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
28+
'@typescript-eslint/no-explicit-any': 'off',
29+
'@typescript-eslint/no-namespace': 'off',
30+
'@typescript-eslint/no-this-alias': [
31+
'error',
32+
{
33+
allowedNames: ['self'] // Allow `const self = this`
34+
}
35+
],
36+
'@typescript-eslint/no-use-before-define': 'off',
37+
'@typescript-eslint/quotes': [
38+
'error',
39+
'single',
40+
{ avoidEscape: true, allowTemplateLiterals: false }
41+
],
42+
curly: ['error', 'all'],
43+
eqeqeq: 'error',
44+
'prefer-arrow-callback': 'error'
45+
},
46+
settings: {
47+
react: {
48+
version: 'detect'
5149
}
52-
};
50+
}
51+
};

.github/ISSUE_TEMPLATE/bug_report.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ about: Create a report to help us improve
44
title: ''
55
labels: bug
66
assignees: ''
7-
87
---
98

109
<!--
@@ -57,7 +56,7 @@ Paste the output from your browser web console here.
5756
</pre>
5857
</details>
5958

60-
<!--
59+
<!--
6160
To open the browser, please refer to the documentation:
6261
Chrome: https://developers.google.com/web/tools/chrome-devtools/open#console
6362
Firefox: https://developer.mozilla.org/en-US/docs/Tools/Web_Console#Opening_the_Web_Console

.github/ISSUE_TEMPLATE/feature_request.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,21 @@ about: Suggest an idea for this project
44
title: ''
55
labels: enhancement
66
assignees: ''
7-
87
---
8+
99
<!--Please check the open issue to see if your feature is not already reported.
1010
If this is the case, +1 it to show your interest.-->
1111

1212
## Is your feature request related to a problem? Please describe.
13+
1314
<!--A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]-->
1415

1516
## Describe the solution you'd like
17+
1618
<!--A clear and concise description of what you want to happen.-->
1719

1820
## Describe alternatives you've considered
21+
1922
<!--A clear and concise description of any alternative solutions or features you've considered.-->
2023

2124
## Additional context

.github/workflows/binder-on-pr.yaml

-29
This file was deleted.

.github/workflows/binder-on-pr.yml

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
name: Binder Badge
2+
on:
3+
pull_request_target:
4+
types: [opened]
5+
6+
jobs:
7+
binder:
8+
runs-on: ubuntu-latest
9+
permissions:
10+
pull-requests: write
11+
steps:
12+
- uses: jupyterlab/maintainer-tools/.github/actions/binder-link@v1
13+
with:
14+
15+
github_token: ${{ secrets.github_token }}
16+

0 commit comments

Comments
 (0)