Skip to content

Commit 67a9173

Browse files
committed
Fix hamburger icon & improve sharing button
More to come to the sharing button Closes compiler-explorer#836
1 parent f9e5dfc commit 67a9173

File tree

5 files changed

+41
-65
lines changed

5 files changed

+41
-65
lines changed

static/explorer.css

+4-13
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,14 @@
1111
visibility: visible;
1212
}
1313

14-
.navbar {
14+
.navbar-default {
15+
border: none;
1516
border-radius: 0;
16-
margin-bottom: 2px;
17-
height: 50px; /* needed to override the darkly settings */
17+
margin-bottom: 1px;
1818
}
1919

2020
.navbar-brand {
21-
padding-top: 0px;
22-
padding-bottom: 0px;
21+
padding: 0;
2322
position: relative;
2423
width: 185px;
2524
}
@@ -40,14 +39,6 @@
4039
display: block;
4140
}
4241

43-
#lang-dropdown {
44-
min-width: 5em;
45-
}
46-
47-
.navbar-inverse .navbar-brand {
48-
font-weight: bold;
49-
}
50-
5142
.nav.nav-tabs {
5243
margin-bottom: 3px !important;
5344
}

static/themes/dark-theme.css

+1-17
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,10 @@ body {
44
background-color: #333 !important;
55
}
66

7-
.navbar-inverse {
7+
.navbar-default {
88
background-color: #333 !important;
99
}
1010

11-
.navbar-inverse .navbar-brand {
12-
color: #aaa !important;
13-
}
14-
15-
.navbar .navbar-toggle {
16-
background-color: #3e3e3e !important;
17-
}
18-
19-
.navbar .navbar-toggle .icon-bar {
20-
background-color: #f2f2f2 !important;
21-
}
22-
23-
.nav.navbar-nav.navbar-left li:hover {
24-
color: #ccc !important;
25-
}
26-
2711
.navbar-brand img.inverse {
2812
display: block !important;
2913
}

static/themes/default-theme.css

+12-8
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,23 @@
11
@import url("~golden-layout/src/css/goldenlayout-light-theme.css");
22

3-
.navbar-inverse {
4-
background-color: #226;
3+
body {
4+
background-color: #FFFFFF;
55
}
66

7-
.navbar-inverse .navbar-brand {
8-
color: #ddd;
7+
.navbar-default {
8+
background-color: #FFFFFF;
99
}
1010

11-
.navbar .navbar-toggle {
12-
background-color: #f2f2f2;
11+
.navbar-default .navbar-nav li a {
12+
color: #337ab7;
13+
}
14+
15+
.navbar-default .navbar-nav li a:hover {
16+
color: #23527c;
1317
}
1418

15-
.navbar .navbar-toggle .icon-bar {
16-
background-color: black;
19+
.navbar-default ul.nav li:hover {
20+
background-color: #eee;
1721
}
1822

1923
.float-link {

views/index.pug

+1-27
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ html(lang="en")
44
include monaco.pug
55
include head.pug
66
body(class=extraBodyClass)
7-
.navbar
7+
.navbar-default
88
.container-fluid
99
.navbar-header
1010
a.navbar-brand(href="#" title="Compiler Explorer")
@@ -63,30 +63,4 @@ html(lang="en")
6363

6464
include templates.pug
6565

66-
.gl_keep.template
67-
.urls
68-
.input-group.urls-container
69-
.input-group-btn
70-
.btn-group.btn-group-sm
71-
button.btn.btn-sm.dropdown-toggle(
72-
data-toggle="dropdown" type="button" aria-haspopup="true" aria-expanded="false")
73-
span.current Short
74-
span.caret
75-
ul.dropdown-menu.sources
76-
if gapiKey
77-
li: a(href="#" data-bind="Short") Short
78-
li: a(href="#" data-bind="Full") Full
79-
li: a(href="#" data-bind="Embed") Embed
80-
li: a(href="#" data-bind="Embed (RO)") Embed (read only)
81-
input.form-control.input-sm.permalink(
82-
type="text" placeholder="Loading" readonly size="1024")
83-
span.input-group-btn
84-
button.btn.btn-sm.clippy(
85-
type="button" data-clipboard-target=".popover .permalink"
86-
title="Copy to clipboard")
87-
img.clippy(
88-
src = require("clippy.svg") width="13px"
89-
alt="Copy to clipboard")
90-
.lang
91-
9266
include popups.pug

views/templates.pug

+23
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,27 @@
11
.gl_keep.template
2+
.urls
3+
.input-group.urls-container
4+
.input-group-btn
5+
.btn-group.btn-group-sm
6+
button.btn.btn-sm.dropdown-toggle(
7+
data-toggle="dropdown" type="button" aria-haspopup="true" aria-expanded="false")
8+
span.current Short
9+
span.caret
10+
ul.dropdown-menu.sources
11+
if gapiKey
12+
li: a(href="#" data-bind="Short") Short
13+
li: a(href="#" data-bind="Full") Full
14+
li: a(href="#" data-bind="Embed") Embed
15+
li: a(href="#" data-bind="Embed (RO)") Embed (read only)
16+
input.form-control.input-sm.permalink(
17+
type="text" placeholder="Loading" readonly size="1024")
18+
span.input-group-btn
19+
button.btn.btn-sm.clippy(
20+
type="button" data-clipboard-target=".popover .permalink"
21+
title="Copy to clipboard")
22+
img.clippy(
23+
src = require("clippy.svg") width="13px"
24+
alt="Copy to clipboard")
225
#codeEditor
326
.top-bar.btn-toolbar(role="toolbar")
427
include font-size.pug

0 commit comments

Comments
 (0)