Skip to content

Commit 9bd4a2b

Browse files
committed
Always try to attach gccdump info
Even if the compiler crashes, the gcc dump files can be useful (to say the least). Try to attach the dumps inconditionnaly of the error state. fixes compiler-explorer#913
1 parent 7c8bb70 commit 9bd4a2b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

lib/base-compiler.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,11 @@ class BaseCompiler {
296296
.then(([asmResult, astResult, gccDumpResult]) => {
297297
asmResult.dirPath = dirPath;
298298
asmResult.compilationOptions = options;
299+
300+
if (this.compiler.supportsGccDump && gccDumpResult) {
301+
asmResult.gccDumpOutput = gccDumpResult;
302+
}
303+
299304
if (asmResult.code !== 0) {
300305
asmResult.asm = "<Compilation failed>";
301306
return asmResult;
@@ -313,10 +318,6 @@ class BaseCompiler {
313318
asmResult.astOutput = astResult;
314319
}
315320

316-
if (this.compiler.supportsGccDump && gccDumpResult) {
317-
asmResult.gccDumpOutput = gccDumpResult;
318-
}
319-
320321
return this.checkOutputFileAndDoPostProcess(asmResult, outputFilename, filters);
321322
});
322323
});

0 commit comments

Comments
 (0)