UART for nrf targets does not implement `machine.Serialer`

[bgould]

This function procedure is incompatible with the machine.Serialer interface:

tinygo/src/machine/machine_nrf.go

Line 174 in 2b21595

func (uart *UART) Configure(config UARTConfig) {

When compiling with -serial=uart, compilation fails when attempting to use machine.Serial as a machine.Serialer like:

cannot use machine.Serial (variable of type *machine.UART) as machine.Serialer value in struct literal: *machine.UART does not implement machine.Serialer (wrong type for method Configure)
                have Configure(machine.UARTConfig)
                want Configure(machine.UARTConfig) error

[bgould]

Upon further investigation ... it appears machine.Serialer is protected by build tags in src/machine/usb.go ... so maybe isn't intended for UART to implement it? Unless there is some detail I'm missing, I think that UART should implement machine.Serialer.

[sago35]

The machine.Serialer interface, if I recall correctly, was introduced for the purpose of tidying up implementations such as -serial=uart. Therefore, it probably does not take into account environments without USB support.

As you are writing, I believe UART should implement machine.Serialer.