Skip to content

Commit 3661908

Browse files
authored
fix: configure snapcraft to build from git on main branch and limit job to it (#275)
This commit fixes the snap workflow which till now ran the same build from existing tag regardless of the workflow/branch that triggered it. Now, I have updated to build with git for the default main branch.
1 parent 0a617e1 commit 3661908

File tree

3 files changed

+0
-79
lines changed

3 files changed

+0
-79
lines changed

.github/workflows/test.yml

-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ jobs:
153153
id: snapcraft-build
154154
with:
155155
snapcraft-args: "-v"
156-
path: "snap/test-snapcraft.yaml"
157156

158157
- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
159158
with:

snap/snapcraft.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,11 @@ parts:
2828
tldr:
2929
plugin: python
3030
source: https://github.com/tldr-pages/tldr-python-client.git
31-
source-tag: $SNAPCRAFT_PROJECT_VERSION
3231
build-environment:
3332
- PATH: ${CRAFT_PART_INSTALL}/bin:${PATH}
3433
- PYTHONPATH: ${CRAFT_PART_INSTALL}/lib/python3.12/site-packages
3534
override-pull: |
3635
craftctl default
37-
sed -i "/data_files=\[('share\/man\/man1', \['docs\/man\/tldr\.1'\])\],/d" setup.py
3836
override-build: |
3937
craftctl default
4038
cd $CRAFT_PART_SRC/docs

snap/test-snapcraft.yaml

-76
This file was deleted.

0 commit comments

Comments
 (0)