Skip to content

Commit 79b7501

Browse files
committed
test(common): Improve SessionCheckName test with test_id and constant list
1 parent 7af5551 commit 79b7501

File tree

1 file changed

+45
-9
lines changed

1 file changed

+45
-9
lines changed

Diff for: tests/test_common.py

+45-9
Original file line numberDiff line numberDiff line change
@@ -203,23 +203,59 @@ def test_tmux_cmd_unicode(session: Session) -> None:
203203
class SessionCheckName(t.NamedTuple):
204204
"""Test fixture for test_session_check_name()."""
205205

206+
test_id: str
206207
session_name: str | None
207208
raises: bool
208209
exc_msg_regex: str | None
209210

210211

212+
SESSION_CHECK_NAME_FIXTURES: list[SessionCheckName] = [
213+
SessionCheckName(
214+
test_id="empty_string",
215+
session_name="",
216+
raises=True,
217+
exc_msg_regex="empty",
218+
),
219+
SessionCheckName(
220+
test_id="none_value",
221+
session_name=None,
222+
raises=True,
223+
exc_msg_regex="empty",
224+
),
225+
SessionCheckName(
226+
test_id="contains_period",
227+
session_name="my great session.",
228+
raises=True,
229+
exc_msg_regex="contains periods",
230+
),
231+
SessionCheckName(
232+
test_id="contains_colon",
233+
session_name="name: great session",
234+
raises=True,
235+
exc_msg_regex="contains colons",
236+
),
237+
SessionCheckName(
238+
test_id="valid_name",
239+
session_name="new great session",
240+
raises=False,
241+
exc_msg_regex=None,
242+
),
243+
SessionCheckName(
244+
test_id="valid_with_special_chars",
245+
session_name="ajf8a3fa83fads,,,a",
246+
raises=False,
247+
exc_msg_regex=None,
248+
),
249+
]
250+
251+
211252
@pytest.mark.parametrize(
212-
SessionCheckName._fields,
213-
[
214-
SessionCheckName("", True, "empty"),
215-
SessionCheckName(None, True, "empty"),
216-
SessionCheckName("my great session.", True, "contains periods"),
217-
SessionCheckName("name: great session", True, "contains colons"),
218-
SessionCheckName("new great session", False, None),
219-
SessionCheckName("ajf8a3fa83fads,,,a", False, None),
220-
],
253+
list(SessionCheckName._fields),
254+
SESSION_CHECK_NAME_FIXTURES,
255+
ids=[test.test_id for test in SESSION_CHECK_NAME_FIXTURES],
221256
)
222257
def test_session_check_name(
258+
test_id: str,
223259
session_name: str | None,
224260
raises: bool,
225261
exc_msg_regex: str | None,

0 commit comments

Comments
 (0)