From cfd9c02f5099e32f3b36c8b8b243fe4a95ad71df Mon Sep 17 00:00:00 2001 From: Florian Loitsch Date: Tue, 10 Dec 2024 16:26:27 +0100 Subject: [PATCH 1/2] Fix documentation for ethernet boards. --- lib/esp32/net/ethernet.toit | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/esp32/net/ethernet.toit b/lib/esp32/net/ethernet.toit index 9066e12c9..8dc649d63 100644 --- a/lib/esp32/net/ethernet.toit +++ b/lib/esp32/net/ethernet.toit @@ -83,10 +83,11 @@ main: # Olimex Ethernet boards The Olimex Ethernet boards (Gateway and ESP32-POE) - need an envelope with an RMII clock output: `esp32-eth-clk-out17`. + need an envelope with an RMII clock output: `esp32-eth-clk-out17` + (WROOM) or `esp32-eth-clk-out0-spiram` (WROVER). -This firmware contains the following sdk-config change (enable - `CONFIG_ETH_RMII_CLK_OUTPUT`): +This firmware contains the sdk-config change to enable + `CONFIG_ETH_RMII_CLK_OUTPUT` (here for the WROOM): ``` --- b/toolchains/esp32/sdkconfig @@ -108,9 +109,8 @@ This firmware contains the following sdk-config change (enable ``` # Lilygo T-Internet-COM - The [Lilygo T-Internet-COM](https://lilygo.cc/products/t-internet-com) is similar - to the Olimex board. It uses the `esp32-eth-clk-out17-spiram` envelope + to the Olimex board. It uses the `esp32-eth-clk-out0-spiram` envelope and GPIO 4 as power pin. The rest is the same. */ class EthernetServiceProvider extends EthernetServiceProviderBase_: From 143e7a1e5a5bfb9da81a48637fc9a443f0953596 Mon Sep 17 00:00:00 2001 From: Florian Loitsch Date: Wed, 11 Dec 2024 10:09:53 +0100 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Kasper Lund --- lib/esp32/net/ethernet.toit | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/esp32/net/ethernet.toit b/lib/esp32/net/ethernet.toit index 8dc649d63..73a831433 100644 --- a/lib/esp32/net/ethernet.toit +++ b/lib/esp32/net/ethernet.toit @@ -86,8 +86,8 @@ The Olimex Ethernet boards (Gateway and ESP32-POE) need an envelope with an RMII clock output: `esp32-eth-clk-out17` (WROOM) or `esp32-eth-clk-out0-spiram` (WROVER). -This firmware contains the sdk-config change to enable - `CONFIG_ETH_RMII_CLK_OUTPUT` (here for the WROOM): +This firmware contains the sdk-config change to enable + `CONFIG_ETH_RMII_CLK_OUTPUT` (here shown for the WROOM): ``` --- b/toolchains/esp32/sdkconfig